Added GameOver(Restart button) and score board. #89
Conversation
|
We can close #85 in favor of this, right? |
| @@ -69,7 +69,23 @@ Flappy.prototype = { | |||
|
|
|||
| //On collision code here. | |||
| if (this._isCollided) | |||
There was a problem hiding this comment.
There is an isCollided method which you should use in favor of the attribute.
|
It looks good! I added some notes on formalities. |
| document.getElementById('layer7').style.display="none"; | ||
| document.getElementById('layer13').style.display="none"; | ||
| document.getElementById('layer14').style.display="none"; | ||
| document.getElementById('layer15').style.display="none"; |
There was a problem hiding this comment.
This is not the style we should use.
Have a look at https://github.com/fossasia/flappy-svg/blob/gh-pages/javascript/background.js#L80
Which layers are you hiding?
|
@niccokunzmann I updated the code check it now. |
|
|
||
| function onCollision(){ | ||
| document.getElementById('layer17').style.display="inline"; |
There was a problem hiding this comment.
please do not use the id. Use the name. it is more descriptive and does not change when editing with Inkscape. You can use these functions:
https://github.com/fossasia/flappy-svg/blob/gh-pages/javascript/layers.js#L60
Also I still do not know from the code what this layer17 is.
| function stopAllBackgrounds(){ | ||
|
|
||
| var keys = Object.keys(backgrounds); | ||
| for (i = 0; i < keys.length; i++){ |
There was a problem hiding this comment.
you can use backgrounds.length
|
@niccokunzmann is that fine now? |
|
no. two small things:
Then I would like to merge it. I understand I am criticizing a lot. Every line you do not write to achieve the goal is a line less that other people need to understand. |
| for (i = 0; i < backgrounds.length; i++){ | ||
| stopMovingBackgound(keys[i]); | ||
| } | ||
| stopMovingBackgound(flappy.stopFlapping()); |
There was a problem hiding this comment.
What is the return value of stopFlapping()?
There was a problem hiding this comment.
Sorry its my mistake its only be flappy.stopFlapping() instead of stopMovingBackgound(flappy.stopFlapping());
|
@mukesh14149 I commented on a line. If you commit, please take the time to write down what the commit means in the message. |
|
Ok @niccokunzmann i will take care from next time. |
|
@mukesh14149 It looks really good! |
…lision Added GameOver(Restart button) and score board.
Fixes issue #69
Here is the preview of starting the game.
Here is the preview when a character hit a obstacle.
After click on restart button it will come back to initial starting screen and right now score board does not have any functionality to do, it is just a layer.