Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index.html #653

Closed
wants to merge 5 commits into from
Closed

Update index.html #653

wants to merge 5 commits into from

Conversation

Devansh3712
Copy link

@Devansh3712 Devansh3712 commented Jan 18, 2020 •
edited

Added link to docker

@Devansh3712
Update index.html
57114a5 
Added link to crunchbase
@Devansh3712 Devansh3712 removed the request for review from abishekvashok January 18, 2020 15:31
@NishithP2004
Copy link
Member

Please provide a preview link.

@Devansh3712
Copy link
Author

@NishithP2004 where to find it?

@NishithP2004
Copy link
Member

I mean the username.GitHub.io/repo link to preview someone's work

@Devansh3712
Copy link
Author

http://devansh3712.github.io/fossasia.org/

NishithP2004
NishithP2004 suggested changes Jan 19, 2020
View reviewed changes
Copy link
Member

@NishithP2004 NishithP2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon isn't loading .
Please refer your preview link.

@NishithP2004
Copy link
Member

That's the issue here, Crunchbase isn't available in the Font awesome library.

Devansh3712
Devansh3712 commented Jan 19, 2020
View reviewed changes
Copy link
Author

@Devansh3712 Devansh3712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added link to docker instead of crunchbase

NishithP2004
NishithP2004 suggested changes Jan 19, 2020
View reviewed changes
Copy link
Member

@NishithP2004 NishithP2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the page already had all the icons but was removed for some reason.

mohitm15
mohitm15 reviewed Jan 28, 2020
View reviewed changes
Copy link

@mohitm15 mohitm15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach the issue you solved via this PR

@Devansh3712 Devansh3712 deleted the patch-1 branch September 1, 2020 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohitm15 mohitm15 mohitm15 approved these changes

@NishithP2004 NishithP2004 NishithP2004 requested changes

@RohitRathore1 RohitRathore1 RohitRathore1 approved these changes

@kushthedude kushthedude kushthedude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Devansh3712 @NishithP2004 @mohitm15 @RohitRathore1 @kushthedude @mariobehling