Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Copyright Text out of the screen #79

Closed
wants to merge 4 commits into from

Conversation

Z-Fikar
Copy link
Contributor

@Z-Fikar Z-Fikar commented Nov 20, 2016

Fixed it considering #67's problem, for the text not to overlapping the other option

Before

1
3

After

2
4
6
5

@mariobehling
Copy link
Member

I don't see necessity of changing this as it is working on standard screen resolutions.

@Z-Fikar
Copy link
Contributor Author

Z-Fikar commented Nov 20, 2016

But It is meant to be applicable to all resolutions, right?

and in my case, in my resolution, the copyright text is just a bit out of screen make it hard to see

and what if some people have smaller resolution than me? they couldn't even see it

@mariobehling
Copy link
Member

Ok, I see.

Could you make it in a way, that it does not move under the above area though? Better have it "disappear" towards the bottom. Do you understand what I mean?

6

@Z-Fikar
Copy link
Contributor Author

Z-Fikar commented Nov 21, 2016

Ok, I have change it and it should be like this
7

@Z-Fikar
Copy link
Contributor Author

Z-Fikar commented Nov 21, 2016

Should I make another PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants