Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve social media links (GCI task) #186

Closed
myfrom opened this issue Nov 2, 2018 · 1 comment
Closed

Improve social media links (GCI task) #186

myfrom opened this issue Nov 2, 2018 · 1 comment

Comments

@myfrom
Copy link
Contributor

myfrom commented Nov 2, 2018

Actual Behaviour

Social media sections in the body of the page and on the footer have different links (in different order, missing icon to website in body).

Expected Behaviour

Social media icons are consistent, lead to the same locations and use the same secure behavior related to opening them in new tab.
As we have a lot of free space, we could enhance the icons in body with popup labels for easier recognition.

Would you like to work on the issue?

I would like to take this issue as part of Google Code-In task.
I should have the solution ready not later than tomorrow.
myfrom added a commit to myfrom/gci18.fossasia.org that referenced this issue Nov 3, 2018
@myfrom
Enhance and sort social media icons
5a2885d 
Related fossasia#186
myfrom added a commit to myfrom/gci18.fossasia.org that referenced this issue Nov 3, 2018
@myfrom
Enhance and sort social media icons
545adbc 
Related fossasia#186
myfrom added a commit to myfrom/gci18.fossasia.org that referenced this issue Nov 3, 2018
@myfrom
Enhance and sort social media icons
f307a6c 
Related fossasia#186
@myfrom myfrom mentioned this issue Nov 3, 2018
Merged
3 tasks
myfrom added a commit to myfrom/gci18.fossasia.org that referenced this issue Nov 3, 2018
@myfrom
Enhance and sort social media icons
d56aff5 
Related fossasia#186
myfrom added a commit to myfrom/gci18.fossasia.org that referenced this issue Nov 7, 2018
@myfrom
Enhance and sort social media icons
c35d742 
Related fossasia#186
@cubetastic33
Copy link
Contributor

I would like to take this issue as part of Google Code-In task.

@rcya1 rcya1 mentioned this issue Nov 21, 2018
Merged
myfrom added a commit to myfrom/gci18.fossasia.org that referenced this issue Nov 24, 2018
@myfrom
Enhance and sort social media icons
0d98c17 
Related fossasia#186
jogendra pushed a commit that referenced this issue Nov 24, 2018
@myfrom @jogendra
Enhance and sort social media icons (#198)
20cd13f 
Related #186
rpotter12 added a commit that referenced this issue Nov 25, 2018
@rpotter12
Merge pull request #420 from cubetastic33/master
b617adc 
Fix issue #186, update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@myfrom @cubetastic33