Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new mentor (GCI) #109

Closed
wants to merge 0 commits into from
Closed

Added new mentor (GCI) #109

wants to merge 0 commits into from

Conversation

Sid911
Copy link
Contributor

@Sid911 Sid911 commented Oct 28, 2018 •
edited

-Added new mentor Sumedhe Dissanayake in the mentor section
-fixes #96
-Github Pages : https://sid911.github.io/gci18/

jogendra
jogendra reviewed Oct 28, 2018
View reviewed changes
Copy link
Member

@jogendra jogendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sid911 Please follow the PR guidelines. Mention issue number and preview link.

@Sid911
Copy link
Contributor Author

Sid911 commented Oct 28, 2018 •
edited

@jogendra Thank you for informing #stillLearning😊........ Do This has to be merged to show to the mentors in task?

@championpaddler
Copy link
Member

@akshatnitd @abishekvashok Ready to be merged.

@rpotter12
Copy link
Member

@Sid911 please resolve conflicts. So that we can merge this

@championpaddler
Copy link
Member

@Sid911 Resolve Conflicts.

fragm3
fragm3 requested changes Oct 28, 2018
View reviewed changes
Copy link
Contributor

@fragm3 fragm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add image of mentor, resolve conflicts

@Sid911
Copy link
Contributor Author

Sid911 commented Oct 28, 2018

Done sir..😊

akshatnitd
akshatnitd reviewed Oct 28, 2018
View reviewed changes
Copy link
Member

@akshatnitd akshatnitd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sid911 You should add the image file i.e, sumedh.jpg in the PR. Make sure to add the file before you commit

@Sid911
Copy link
Contributor Author

Sid911 commented Oct 28, 2018 •
edited

@akshatnitd isn't sumedh.jpeg already present in the image/mentors directory?.... I can't think of a reason to add it in PR if its already there, can you explain?

akshatnitd
akshatnitd reviewed Oct 28, 2018
View reviewed changes
Copy link
Member

@akshatnitd akshatnitd left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image is of Sumedh Nimkarde and not Sumedhe Dissanayake. Can you please add someone from the list as mentioned in the issue?

@Sid911
Copy link
Contributor Author

Sid911 commented Oct 28, 2018

@akshatnitd Is it fine now?....

akshatnitd
akshatnitd reviewed Oct 28, 2018
View reviewed changes
Copy link
Member

@akshatnitd akshatnitd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see the name on the list. Please add someone from the list.

@Sid911
Copy link
Contributor Author

Sid911 commented Oct 28, 2018 •
edited

Hong Phuc Dang, Harshit Prasad... anyone of these are on the list? @akshatnitd

@akshatnitd
Copy link
Member

The list is present on the issue description - #96

@Sid911
Copy link
Contributor Author

Sid911 commented Oct 28, 2018 •
edited

AT last done... I hope so😊💻 @akshatnitd

supunTE
supunTE suggested changes Oct 28, 2018
View reviewed changes
Copy link
Member

@supunTE supunTE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash commits

codedsun
codedsun requested changes Oct 28, 2018
View reviewed changes
Copy link

@codedsun codedsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits!

championpaddler
championpaddler requested changes Oct 29, 2018
View reviewed changes
Copy link
Member

@championpaddler championpaddler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sid911 Squash commits.

sarnava1
sarnava1 reviewed Oct 29, 2018
View reviewed changes
Copy link
Member

@sarnava1 sarnava1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash the commits and then it is good to go!

simsausaurabh
simsausaurabh reviewed Oct 29, 2018
View reviewed changes
Copy link
Member

@simsausaurabh simsausaurabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sid911 Everything looks good, try to update the same commit with the changes. It would help us mentors to review the PR easily and a lot of time can be saved. I hope it helps.

@Sid911
Copy link
Contributor Author

Sid911 commented Oct 29, 2018

I will get that done.... 😊

@Sid911 Sid911 closed this Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshatnitd akshatnitd akshatnitd left review comments

@simsausaurabh simsausaurabh simsausaurabh left review comments

@jogendra jogendra jogendra left review comments

@sarnava1 sarnava1 sarnava1 left review comments

@championpaddler championpaddler championpaddler requested changes

@fragm3 fragm3 fragm3 requested changes

@codedsun codedsun codedsun requested changes

@supunTE supunTE supunTE requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some mentors are missing from the Mentors section
10 participants
@Sid911 @championpaddler @rpotter12 @akshatnitd @simsausaurabh @fragm3 @codedsun @jogendra @sarnava1 @supunTE