Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #167 :Customised Footer #171

Merged
merged 1 commit into from Nov 1, 2018
Merged

Fixes #167 :Customised Footer #171

merged 1 commit into from Nov 1, 2018

Conversation

saarthakchats
Copy link
Member

Please read and understand everything below
Do not delete any text other than where you are instructed.

Students: If one of them is applicable to you. Please check it.

Check by changing each [ ] to [x] Please take note of the whitespace as it matters.

  • Included a Preview link and screenshot showning after and before the changes.
  • Included a description of change below.
  • Squashed the commits.

Changes done in this Pull Request

Description / Changes

  • Linked Twitter feed
  • Added blog links
  • Removed template content

Copy link
Member

@sarnava1 sarnava1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good but I can see that the links to the recent events and blogs are hard coded. Can we link that to some kind of a data base from where it will be fetched automatically?

@fragm3 fragm3 merged commit a45a9b7 into fossasia:master Nov 1, 2018
@jogendra
Copy link
Member

jogendra commented Nov 1, 2018

@fragm3 Please review the PR before merging it. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants