Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #49 , Fixes #29 : Added social icons to social section and footer #50

Closed
wants to merge 1 commit into from
Closed

Conversation

saarthakchats
Copy link
Member

@saarthakchats saarthakchats commented Oct 26, 2018

Please read and understand everything below
Do not delete any text other than where you are instructed.

Students: If one of them is applicable to you. Please check it.

Check by changing each [ ] to [x] Please take note of the whitespace as it matters.

  • Included a Preview link and screenshot showning after and before the changes.
  • Included a description of change below.
  • Squashed the commits.

Changes done in this Pull Request

Description / Changes

  • Added more Social Media Icons
  • Added Icons and links to footer

@liveHarshit
Copy link
Member

liveHarshit commented Oct 26, 2018

Do not mention fixes for #29 in the description, It will close this issue which is assigned to a task. Only mention for #49. You can mention both in last of your commit message.

@saarthakchats
Copy link
Member Author

Okay

@saarthakchats
Copy link
Member Author

Done @liveHarshit

@liveHarshit
Copy link
Member

I think the last PR is for same issue #49, you have to wait.

@saarthakchats
Copy link
Member Author

@liveHarshit
That is for the footer

@saarthakchats
Copy link
Member Author

If that one is merged, can I remove the footer code from mine and keep it limited to the social section

@liveHarshit
Copy link
Member

It is for setting the target to blank.

@saarthakchats
Copy link
Member Author

My PR is unrelated then, it has nothing to do with target to blank

@liveHarshit
Copy link
Member

Change commit message to Add social icons to social section and footer (#29)

@saarthakchats
Copy link
Member Author

@liveHarshit here

@saarthakchats
Copy link
Member Author

@liveHarshit @abishekvashok
Please merge.. i'll get conflicts again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants