New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #731: Update travis & docs, and remove automatic deployment to gh-pages branch #733
Fixes #731: Update travis & docs, and remove automatic deployment to gh-pages branch #733
Conversation
20e3e27
to
dbedaea
Compare
Codecov Report
@@ Coverage Diff @@
## development #733 +/- ##
============================================
Coverage 53.41% 53.41%
============================================
Files 107 107
Lines 2881 2881
Branches 374 374
============================================
Hits 1539 1539
Misses 1218 1218
Partials 124 124 Continue to review full report at Codecov.
|
@singhpratyush @hemantjadon @praveenojha33 please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Deplpoyment to Github pages should stay. There is no reason to move away from gh-pages. |
You can deploy master to gh-pages and development to heroku for testing, but keep gh-pages, please. |
@mariobehling Ok, sorry for that. I am keeping master branch deployment to gh-pages. We need to deploy development on heroku for testing. gh-pages should not have both of these deployments(from master and development). So for creating deployment of development branch to heroku for testing, it requires access to repo. Could you please create a repo on heroku for the same? |
dbedaea
to
d28f43d
Compare
@hemantjadon please review. |
d28f43d
to
a6571a0
Compare
@mariobehling please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simsausaurabh As this PR is for development branch, I think deploy.sh
should be updated to deploy on heroku. Earlier in this PR you removed deploy.sh
from .travis.yml
, but why you included it again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Changes proposed in this pull request
Screenshots (if appropriate) Not Applicable.
Link to live demo: http://pr-733-fossasia-loklaksearch.surge.sh
Closes #731