Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #731: Update travis & docs, and remove automatic deployment to gh-pages branch #733

Merged
merged 1 commit into from Jun 2, 2018

Conversation

simsausaurabh
Copy link
Member

@simsausaurabh simsausaurabh commented Jun 1, 2018

Changes proposed in this pull request

  • Updated branch policy.
  • Updated node and npm version in requirements.
  • Updated travis to check builds on development branch.
  • Removed deployment to gh-pages.

Screenshots (if appropriate) Not Applicable.

Link to live demo: http://pr-733-fossasia-loklaksearch.surge.sh

Closes #731

@codecov
Copy link

codecov bot commented Jun 1, 2018

Codecov Report

Merging #733 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #733   +/-   ##
============================================
  Coverage        53.41%   53.41%           
============================================
  Files              107      107           
  Lines             2881     2881           
  Branches           374      374           
============================================
  Hits              1539     1539           
  Misses            1218     1218           
  Partials           124      124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eaf03f...a6571a0. Read the comment docs.

@simsausaurabh
Copy link
Member Author

simsausaurabh commented Jun 1, 2018

@singhpratyush @hemantjadon @praveenojha33 please review.

@simsausaurabh simsausaurabh changed the title Fixes #731: Update branch policy and requirements in README Fixes #731: Update travis & docs, and remove automatic deployment to gh-pages branch Jun 1, 2018
Copy link
Member

@praveenojha33 praveenojha33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mariobehling
Copy link
Member

Deplpoyment to Github pages should stay. There is no reason to move away from gh-pages.

@mariobehling
Copy link
Member

You can deploy master to gh-pages and development to heroku for testing, but keep gh-pages, please.

@simsausaurabh
Copy link
Member Author

@mariobehling Ok, sorry for that. I am keeping master branch deployment to gh-pages. We need to deploy development on heroku for testing. gh-pages should not have both of these deployments(from master and development). So for creating deployment of development branch to heroku for testing, it requires access to repo. Could you please create a repo on heroku for the same?

@simsausaurabh
Copy link
Member Author

@hemantjadon please review.

@simsausaurabh
Copy link
Member Author

@mariobehling please review.

Copy link
Member

@praveenojha33 praveenojha33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simsausaurabh As this PR is for development branch, I think deploy.sh should be updated to deploy on heroku. Earlier in this PR you removed deploy.sh from .travis.yml , but why you included it again?

Copy link
Contributor

@hemantjadon hemantjadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hemantjadon hemantjadon closed this Jun 2, 2018
@hemantjadon hemantjadon merged commit 9594abf into fossasia:development Jun 2, 2018
@simsausaurabh simsausaurabh deleted the updatebranchPolicy branch June 2, 2018 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants