Fixes #732: Create an automatic deployment of development branch on surge #737
Conversation
Codecov Report
@@ Coverage Diff @@
## development #737 +/- ##
============================================
Coverage 52.34% 52.34%
============================================
Files 97 97
Lines 2470 2470
Branches 271 271
============================================
Hits 1293 1293
Misses 1150 1150
Partials 27 27Continue to review full report at Codecov.
|
|
@hemantjadon @singhpratyush @sudheesh001 @jigyasa-grover @daminisatya @praveenojha33 please review. |
development_deploy.sh
Outdated
|
|
||
| export SURGE_LOGIN=test@example.co.in | ||
| # Token of a dummy account. | ||
| export SURGE_TOKEN=d1c28a7a75967cc2b4c852cca0d12206 |
There was a problem hiding this comment.
This is probably a bad idea. These tokens (new generated ones) should go into the travis environment variables on travis' CI and shouldn't be publicly exposed in any of the files. You need to encrypt these tokens before they're merged to maintain security.
There was a problem hiding this comment.
The surge tokens were already used in this project previously. I am not sure about encrypting though. It is publicly available on fossasia's blog post(https://blog.fossasia.org/installing-the-loklak-search-and-deploying-it-to-surge). There might be a method to not to share this token, but it requires access to repo. Or someone with right access would have to push travis yml configuration on respective travis account. For more info please see: https://docs.travis-ci.com/user/deployment/surge/
Please guide me further.
There was a problem hiding this comment.
@sudheesh001 please review.
|
@simsausaurabh Will it be a good idea to use surge for deployment of development branch? Currently I am unable to open features like Media Wall etc on surge. |
|
@praveenojha33 I am currently looking for how to handle routes on spa hosted on surge, since it does not get automatically handled. I mean when we hit refresh Error is shown Something like 404.html in gh-pages and media-wall-component is also not accessible on surge. If not possible I'll go on with deploying development on heroku and keeping master on gh-pages, after discussing with mentors. |
|
It is sufficient if it works after accessing the site from the main page. |
Changes proposed in this pull request
Screenshots (if appropriate) Not applicable.
Link to live demo: http://pr-737-fossasia-loklaksearch.surge.sh
development branch deployment link: https://development-test-loklaksearch.surge.sh/
Closes #732