Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent #738: Fix CSS issues in development #740

Merged
merged 1 commit into from Jun 3, 2018

Conversation

simsausaurabh
Copy link
Member

Changes proposed in this pull request

Link to live demo:http://pr-740-fossasia-loklaksearch.surge.sh

Closes #

@codecov
Copy link

codecov bot commented Jun 3, 2018

Codecov Report

Merging #740 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #740   +/-   ##
============================================
  Coverage        52.34%   52.34%           
============================================
  Files               97       97           
  Lines             2470     2470           
  Branches           271      271           
============================================
  Hits              1293     1293           
  Misses            1150     1150           
  Partials            27       27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90003f1...e7f4f06. Read the comment docs.

@simsausaurabh
Copy link
Member Author

@hemantjadon please review.

I think development branch needs to enabled in project settings since its not getting analyzed by Codacy?

screenshot from 2018-06-03 19-25-31

@simsausaurabh
Copy link
Member Author

Before:
screenshot from 2018-06-03 19-32-39

After:
screenshot from 2018-06-03 19-31-07

I am working on other UI issues and broken search results.

tslint.json Outdated
@@ -119,7 +119,7 @@
"no-output-on-prefix": true,
"use-input-property-decorator": true,
"use-output-property-decorator": true,
"use-host-property-decorator": true,
"use-host-property-decorator": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should not be turned off.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry I was turning it to true, didn't realise it was already by taking reference from earlier branch.

@simsausaurabh
Copy link
Member Author

Oh, sorry I was turning it to true, didn't realise it was already by taking reference from earlier branch. I have updated the changes please review. @hemantjadon

@hemantjadon hemantjadon merged commit b30a3ce into fossasia:development Jun 3, 2018
@simsausaurabh simsausaurabh deleted the fixDevUi branch June 3, 2018 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants