New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parent #738: Fix CSS issues in development #740
Conversation
Codecov Report
@@ Coverage Diff @@
## development #740 +/- ##
============================================
Coverage 52.34% 52.34%
============================================
Files 97 97
Lines 2470 2470
Branches 271 271
============================================
Hits 1293 1293
Misses 1150 1150
Partials 27 27 Continue to review full report at Codecov.
|
@hemantjadon please review. I think development branch needs to enabled in project settings since its not getting analyzed by Codacy? |
tslint.json
Outdated
@@ -119,7 +119,7 @@ | |||
"no-output-on-prefix": true, | |||
"use-input-property-decorator": true, | |||
"use-output-property-decorator": true, | |||
"use-host-property-decorator": true, | |||
"use-host-property-decorator": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should not be turned off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry I was turning it to true, didn't realise it was already by taking reference from earlier branch.
Oh, sorry I was turning it to true, didn't realise it was already by taking reference from earlier branch. I have updated the changes please review. @hemantjadon |
Changes proposed in this pull request
Screenshots (if appropriate)
Link to live demo:http://pr-740-fossasia-loklaksearch.surge.sh
Closes #