New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #755: Repeating data in sidebar, and Adress: #716 console errors #756
Conversation
Codecov Report
@@ Coverage Diff @@
## development #756 +/- ##
===============================================
- Coverage 52.42% 52.37% -0.05%
===============================================
Files 99 99
Lines 2499 2501 +2
Branches 276 276
===============================================
Hits 1310 1310
- Misses 1161 1163 +2
Partials 28 28
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @simsausaurabh Please attach a screenshot of the bug or mention steps how to produce it. I cannot find a screenshot in issue #755 also mention which sub issue is solved for parent #716
@praveenojha33 I have updated the issue with snapshot and steps involved to reproduce it. Please review again 👍 |
@praveenojha33 The other are errors on console are due to the json call back error, I am working on it but the current issue does not references that. They have been come into existence after project updation. And the UI bugs are not actually UI bugs, those are the issue with angular material (mat-icon, mat suggestion, etc). The code parts containing those mat properties needs to be changed since after project udpation the mat modules have changed to work as expected. Note: The console error for user-info box description was leading to sequencing logging of errors which kept on increasing upto 4000 times and so on, which lead the website to hang. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
… console errors
Please fix other issues which are appearing in the console. Also there are are lots of issues with UI which might be due to Angular Material. There is one more problem the tweets which are shown have same people tagged more than one. Also please remove . Please change commit message as #716 is not completely fixed in this issue. |
@praveenojha33 I have updated the title and commit message. I will be solving the rest of issues quickly. Please review again 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Changes proposed in this pull request
Screenshots (if appropriate)
Link to live demo: http://pr-756-fossasia-loklaksearch.surge.sh
Closes #755
Parent Issue: #716