Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #755: Repeating data in sidebar, and Adress: #716 console errors #756

Merged
merged 1 commit into from Jun 18, 2018

Conversation

simsausaurabh
Copy link
Member

@simsausaurabh simsausaurabh commented Jun 17, 2018

Changes proposed in this pull request

  • Fixed console error for user-info with no description.
  • Fixed repeated top twitter and top mentions from sidebar.
  • There are some hashtags which seems to be repeated but they are actually the first elements of array (may contain different elements). It will be fixed with images of sidebar.
  • Updated the router link queries for sidebar users.

Screenshots (if appropriate)

Link to live demo: http://pr-756-fossasia-loklaksearch.surge.sh

Closes #755
Parent Issue: #716

@codecov
Copy link

codecov bot commented Jun 17, 2018

Codecov Report

Merging #756 into development will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #756      +/-   ##
===============================================
- Coverage        52.42%   52.37%   -0.05%     
===============================================
  Files               99       99              
  Lines             2499     2501       +2     
  Branches           276      276              
===============================================
  Hits              1310     1310              
- Misses            1161     1163       +2     
  Partials            28       28
Impacted Files Coverage Δ
src/app/feed/info-box/info-box.component.ts 20% <0%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d691dc...79ed6e6. Read the comment docs.

Copy link
Member

@praveenojha33 praveenojha33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @simsausaurabh Please attach a screenshot of the bug or mention steps how to produce it. I cannot find a screenshot in issue #755 also mention which sub issue is solved for parent #716

@simsausaurabh
Copy link
Member Author

@praveenojha33 I have updated the issue with snapshot and steps involved to reproduce it. Please review again 👍

@praveenojha33
Copy link
Member

praveenojha33 commented Jun 17, 2018

Apart from repeating Hashtags
There are still a lot of errors coming in console.
image
Also there are some UI issues which are appearing at bottom
image

@simsausaurabh
Copy link
Member Author

simsausaurabh commented Jun 17, 2018

@praveenojha33 The other are errors on console are due to the json call back error, I am working on it but the current issue does not references that. They have been come into existence after project updation. And the UI bugs are not actually UI bugs, those are the issue with angular material (mat-icon, mat suggestion, etc). The code parts containing those mat properties needs to be changed since after project udpation the mat modules have changed to work as expected.

Note: The console error for user-info box description was leading to sequencing logging of errors which kept on increasing upto 4000 times and so on, which lead the website to hang.

Copy link
Member

@praveenojha33 praveenojha33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@simsausaurabh simsausaurabh changed the title Fixes #755, #716: Fix repeating data in sidebar and console errors Fixes #755: Repeating data in sidebar, and Adress: #716 console errors Jun 17, 2018
@praveenojha33
Copy link
Member

Please fix other issues which are appearing in the console. Also there are are lots of issues with UI which might be due to Angular Material. There is one more problem the tweets which are shown have same people tagged more than one. Also please remove . Please change commit message as #716 is not completely fixed in this issue.

@simsausaurabh
Copy link
Member Author

@praveenojha33 I have updated the title and commit message. I will be solving the rest of issues quickly. Please review again 👍

Copy link
Member

@praveenojha33 praveenojha33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mariobehling mariobehling merged commit d805efb into fossasia:development Jun 18, 2018
@simsausaurabh simsausaurabh deleted the sidebar branch June 21, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console error on no description for user-info-box and repeating top twitters and top mentions
3 participants