Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #764: Add new test for reg-exp utility to increase test coverage #765

Merged
merged 1 commit into from Jun 20, 2018

Conversation

simsausaurabh
Copy link
Member

@simsausaurabh simsausaurabh commented Jun 19, 2018

Changes proposed in this pull request

  • Added new test case file for reg-exp utility function.
  • 13 new test units are added. Now total test units are: 170+13 = 183.

Screenshots (if appropriate)

Link to live demo: http://pr-765-fossasia-loklaksearch.surge.sh

Closes #764

@codecov
Copy link

codecov bot commented Jun 19, 2018

Codecov Report

Merging #765 into development will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #765      +/-   ##
==============================================
+ Coverage        51.66%   51.7%   +0.04%     
==============================================
  Files               99      99              
  Lines             2499    2499              
  Branches           278     278              
==============================================
+ Hits              1291    1292       +1     
  Misses            1180    1180              
+ Partials            28      27       -1
Impacted Files Coverage Δ
src/app/lazy-img/lazy-img.service.ts 64.44% <0%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59c45b7...0da2cbb. Read the comment docs.

@simsausaurabh
Copy link
Member Author

@praveenojha33 @singhpratyush Please review.

Copy link
Member

@praveenojha33 praveenojha33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mariobehling mariobehling merged commit e465db7 into fossasia:development Jun 20, 2018
@simsausaurabh simsausaurabh deleted the test1 branch June 20, 2018 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants