Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #758: Fix Service Box display mat property #769

Merged
merged 1 commit into from Jun 21, 2018

Conversation

simsausaurabh
Copy link
Member

Changes proposed in this pull request

  • Fixed Service Box mat property and adjusted its position.
  • Made it to white on home page.
  • Fixed its color on results page.
  • It acquires background color of page.

Screenshots (if appropriate)

screenshot from 2018-06-21 12-28-43

screenshot from 2018-06-21 12-29-01

screenshot from 2018-06-21 12-28-52

Link to live demo: http://pr-769-fossasia-loklaksearch.surge.sh

Closes #
Parent Issue: #758

@simsausaurabh
Copy link
Member Author

@praveenojha33 Please review.

@codecov
Copy link

codecov bot commented Jun 21, 2018

Codecov Report

Merging #769 into development will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #769      +/-   ##
===============================================
- Coverage        51.63%   51.59%   -0.04%     
===============================================
  Files              100      100              
  Lines             2504     2504              
  Branches           278      278              
===============================================
- Hits              1293     1292       -1     
  Misses            1184     1184              
- Partials            27       28       +1
Impacted Files Coverage Δ
src/app/lazy-img/lazy-img.service.ts 62.22% <0%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 202d1d1...a13caa2. Read the comment docs.

Copy link
Member

@praveenojha33 praveenojha33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@simsausaurabh
Copy link
Member Author

@mariobehling Please review.

@mariobehling mariobehling merged commit 4cf8a0e into fossasia:development Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants