Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selection of hashtag-link sometimes fails #286

Closed
Orbiter opened this issue Jul 4, 2015 · 2 comments
Closed

selection of hashtag-link sometimes fails #286

Orbiter opened this issue Jul 4, 2015 · 2 comments

Comments

@Orbiter
Copy link
Contributor

Orbiter commented Jul 4, 2015

hashtags shall be marked as link. That moslty works, but in some cases not:

hashtagfail

This may be a problem with umlaute, but strangely it works with the word "Köln" but not with "München".

@sudheesh001
Copy link
Member

The hastag regex has

var hashtagReg = /#([\wäöå]+)/gi;

so the ü character is missing and has to be converted into

var hashtagReg = /#([\wäöåü]+)/gi;

But this would just solve it for this case, what are the other possible cases in which this could fail ?

@mariobehling
Copy link
Member

Please try out all kinds of special local characters and other languages as well. @sudheesh001 Please do some tests as well.

@mariobehling mariobehling added this to the Milestone 2.5 Sprint milestone Jul 4, 2015
@sudheesh001 sudheesh001 self-assigned this Jul 4, 2015
prasht63 added a commit that referenced this issue Jul 5, 2015
Fixes #286 Allows non english character based hashtags to be correctly identified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants