Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change all exposed MutableLiveData to LiveData #794

Merged
merged 5 commits into from Dec 29, 2018
Merged

fix: Change all exposed MutableLiveData to LiveData #794

merged 5 commits into from Dec 29, 2018

Conversation

GOVINDDIXIT
Copy link
Member

Fixes #782

@GOVINDDIXIT GOVINDDIXIT changed the title fix: changed all exposed MutableLiveData to live data fix: changed all xposed MutableLiveData to live data Dec 29, 2018
@fossasia fossasia deleted a comment Dec 29, 2018
@fossasia fossasia deleted a comment Dec 29, 2018
@fossasia fossasia deleted a comment Dec 29, 2018
@fossasia fossasia deleted a comment Dec 29, 2018
@iamareebjamal
Copy link
Member

There are several indentation issues

@fossasia fossasia deleted a comment Dec 29, 2018
@fossasia fossasia deleted a comment Dec 29, 2018
@fossasia fossasia deleted a comment Dec 29, 2018
@fossasia fossasia deleted a comment Dec 29, 2018
@fossasia fossasia deleted a comment Dec 29, 2018
})
avatarUrl = url
), id
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a lot of indentation problems

@fossasia fossasia deleted a comment Dec 29, 2018
@fossasia fossasia deleted a comment Dec 29, 2018
@fossasia fossasia deleted a comment Dec 29, 2018
@fossasia fossasia deleted a comment Dec 29, 2018
@GOVINDDIXIT
Copy link
Member Author

GOVINDDIXIT commented Dec 29, 2018

formatted every file used here using autoformat, IDE setup with the official Kotlin coding style

@iamareebjamal iamareebjamal changed the title fix: changed all xposed MutableLiveData to live data fix: Change all exposed MutableLiveData to LiveData Dec 29, 2018
@iamareebjamal iamareebjamal merged commit 4df3c9b into fossasia:development Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants