fix: Change all exposed MutableLiveData to LiveData (#794)

fossasia · Dec 29, 2018 · 4df3c9b · 4df3c9b
1 parent c0f2260
commit 4df3c9b
Show file tree

Hide file tree

Showing 16 changed files with 714 additions and 574 deletions.
diff --git a/app/src/main/java/org/fossasia/openevent/general/about/AboutEventViewModel.kt b/app/src/main/java/org/fossasia/openevent/general/about/AboutEventViewModel.kt
@@ -1,5 +1,6 @@
 package org.fossasia.openevent.general.about
 
+import androidx.lifecycle.LiveData
 import androidx.lifecycle.MutableLiveData
 import androidx.lifecycle.ViewModel
 import io.reactivex.android.schedulers.AndroidSchedulers
@@ -12,28 +13,33 @@ import timber.log.Timber
 class AboutEventViewModel(private val eventService: EventService) : ViewModel() {
 
     private val compositeDisposable = CompositeDisposable()
-    val progressAboutEvent = MutableLiveData<Boolean>()
-    val event = MutableLiveData<Event>()
-    val error = MutableLiveData<String>()
+
+    private val mutableProgressAboutEvent = MutableLiveData<Boolean>()
+    val progressAboutEvent: LiveData<Boolean> = mutableProgressAboutEvent
+    private val mutableEvent = MutableLiveData<Event>()
+    val event: LiveData<Event> = mutableEvent
+    private val mutableError = MutableLiveData<String>()
+    val error: LiveData<String> = mutableError
 
     fun loadEvent(id: Long) {
         if (id.equals(-1)) {
-            error.value = "Error fetching event"
+            mutableError.value = "Error fetching event"
             return
         }
         compositeDisposable.add(eventService.getEvent(id)
-                .subscribeOn(Schedulers.io())
-                .observeOn(AndroidSchedulers.mainThread())
-                .doOnSubscribe({
-                    progressAboutEvent.value = true
-                }).doFinally({
-                    progressAboutEvent.value = false
-                }).subscribe({ eventList ->
-                    event.value = eventList
-                }, {
-                    error.value = "Error fetching event"
-                    Timber.e(it, "Error fetching event %d", id)
-                }))
+            .subscribeOn(Schedulers.io())
+            .observeOn(AndroidSchedulers.mainThread())
+            .doOnSubscribe({
+                mutableProgressAboutEvent.value = true
+            }).doFinally({
+                mutableProgressAboutEvent.value = false
+            }).subscribe({ eventList ->
+                mutableEvent.value = eventList
+            }, {
+                mutableError.value = "Error fetching event"
+                Timber.e(it, "Error fetching event %d", id)
+            })
+        )
     }
 
     override fun onCleared() {