Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back navigation in ActionBar doesn't work when "difficulty fetching event" displayed #1436

Closed
anhanh11001 opened this issue Mar 26, 2019 · 0 comments
Closed

Back navigation in ActionBar doesn't work when "difficulty fetching event" displayed #1436

anhanh11001 opened this issue Mar 26, 2019 · 0 comments

Comments

@anhanh11001
Copy link
Contributor

Describe the bug
Back navigation in header doesn't work when "difficulty fetching event" displayed

Screenshots

Would you like to work on the issue?
Yes
@anhanh11001 anhanh11001 changed the title Back navigation in header doesn't work when "difficulty fetching event" displayed Back navigation in ActionBar doesn't work when "difficulty fetching event" displayed Mar 26, 2019
@anhanh11001 anhanh11001 mentioned this issue Mar 26, 2019
Merged
iamareebjamal pushed a commit that referenced this issue Mar 28, 2019
@anhanh11001 @iamareebjamal
fix: back button in actionbar (#1442)
34298f1 
Details:
Previously, when error fetching is displayed, other menu item in actionbar is hided by setting setActionMenu to false. This made the android.R.id.home menu item stop working.

So instead of setting the hasActionMenu to false, setting the menu item visibility to false solve problem

Fixes: #1436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anhanh11001