Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to remove liked events. #2553

Closed
1 of 2 tasks
VaibhavDM opened this issue Jan 6, 2020 · 33 comments
Closed
1 of 2 tasks

Not able to remove liked events. #2553

VaibhavDM opened this issue Jan 6, 2020 · 33 comments

Comments

@VaibhavDM
Copy link

VaibhavDM commented Jan 6, 2020

Describe the bug
When you try to remove liked event it first shows that the event is deleted but the event is not deleted.

To Reproduce

  1. Go to likes menu
  2. Click on the heart icon to remove an event from liked events
  3. It first shows that event is deleted.
  4. Then an error will occur

Expected behavior

When we click on heart icon the event must be remove from liked events.

Screenshots

WhatsApp Image 2020-01-06 at 20 58 59 (2)
WhatsApp Image 2020-01-06 at 20 58 59 (1)
WhatsApp Image 2020-01-06 at 20 58 59

Smartphone Info:

Device Vivo Z1pro
Android Version Pie 9

Would you like to work on the issue?

  • Yes
  • No
@VaibhavDM VaibhavDM reopened this Jan 6, 2020
@VaibhavDM VaibhavDM changed the title Not able to delete liked events. Not able to remove liked events. Jan 6, 2020
@liveHarshit
Copy link
Member

Attach GIF instead.

@rob729
Copy link
Contributor

rob729 commented Jan 13, 2020

@liveHarshit Can I work on this issue?

@VaibhavDM
Copy link
Author

VaibhavDM commented Jan 14, 2020 via email

@rob729
Copy link
Contributor

rob729 commented Jan 14, 2020

@rob729
Copy link
Contributor

rob729 commented Jan 20, 2020

@liveHarshit @iamareebjamal This seems to be a server-side problem. Should I open an issue on the server-side?

@liveHarshit
Copy link
Member

@liveHarshit @iamareebjamal This seems to be a server-side problem. Should I open an issue on the server-side?

Can't say. Provide server response.

@rob729
Copy link
Contributor

rob729 commented Jan 20, 2020

{"errors": [{"status": 409, "source": {"pointer": "/data/relationships/event"}, "title": "Conflict", "detail": "Event already favourited"}], "jsonapi": {"version": "1.0"}}

@rob729
Copy link
Contributor

rob729 commented Jan 21, 2020

@liveHarshit @iamareebjamal This seems to be a server-side problem. Should I open an issue on the server-side?

?? @liveHarshit @iamareebjamal

@iamareebjamal
Copy link
Member

Yes

@codedsun
Copy link
Contributor

@rob729 - Please open an issue on the server. Thankyou

@codedsun
Copy link
Contributor

@rob729 - The server side issue is fixed, please check the app side.

@rob729
Copy link
Contributor

rob729 commented Jan 22, 2020

Ok

@rob729
Copy link
Contributor

rob729 commented Jan 22, 2020

@codedsun The issue is still present in the app.

@iamareebjamal
Copy link
Member

You should be using the dev server

@codedsun
Copy link
Contributor

codedsun commented Jan 22, 2020

@rob729 - The release has not been made yet, so please test in on dev server currently. The fix will go to prod once we make a release. Thankyou!

@rob729
Copy link
Contributor

rob729 commented Jan 22, 2020

I am using the debug version of the app.
Does https://open-event-api-dev.herokuapp.com/v1/ indicates dev server?

@codedsun
Copy link
Contributor

codedsun commented Jan 22, 2020

@rob729
Copy link
Contributor

rob729 commented Jan 22, 2020

I am still getting the error.
404 NOT FOUND https://open-event-api-dev.herokuapp.com/v1/user-favourite-events/63

{"errors": [{"status": 404, "source": {"pointer": ""}, "title": "Object not found", "detail": "Object Not Found"}], "jsonapi": {"version": "1.0"}}

@codedsun
Copy link
Contributor

codedsun commented Jan 22, 2020

@rob729 - Their is some bug on the app side. When I try to favourite an event - it hits the api

POST https://open-event-api-dev.herokuapp.com/v1/user-favourite-events which is fine

then i want to remove this favourite event - only from the UI the favourite icon is removed from that event and transferred to the next event in the list .

Following, when I try to remove that favourite event. the app hits
DELETE https://open-event-api-dev.herokuapp.com/v1/user-favourite-events/126 (which was the event I didn't favourited, but the app side shows)

It gives the error
{"errors": [{"status": 404, "source": {"pointer": ""}, "title": "Object not found", "detail": "Object Not Found"}], "jsonapi": {"version": "1.0"}}

@codedsun
Copy link
Contributor

codedsun commented Jan 22, 2020

The API end points are working fine and you can hit from postman and check.
The documentation is present here https://open-event-api-dev.herokuapp.com

@codedsun
Copy link
Contributor

ezgif com-video-to-gif

Reference

@codedsun
Copy link
Contributor

So, basically in the list, the event I favourited is first but it shows the second. Please look into this.

@rob729
Copy link
Contributor

rob729 commented Jan 22, 2020

Ok

@rob729
Copy link
Contributor

rob729 commented Jan 22, 2020

In my case, I am getting an error when I am trying to like an event.
409 CONFLICT https://open-event-api-dev.herokuapp.com/v1/user-favourite-events

@codedsun
Copy link
Contributor

It's because you have liked that event previously and the UI of app doesn't shows that. I already mentioned that their's is the misplacement of favourite events.

So, basically in the list, the event I favourited is first but it shows the second. Please look into thiss

@rob729
Copy link
Contributor

rob729 commented Jan 24, 2020


@codedsun I did a fresh install of the app and now I am not getting the error when I am liking the event but while removing the liked event I am getting the following error.

404 NOT FOUND https://open-event-api-dev.herokuapp.com/v1/user-favourite-events/16

{"errors": [{"status": 404, "source": {"pointer": ""}, "title": "Object not found", "detail": "Object Not Found"}], "jsonapi": {"version": "1.0"}}

Do you have any idea what could be the possible reason for this error?

@codedsun
Copy link
Contributor

@rob729 - I told you that there is a misplacement of the favourite button in UI. Please use POSTMAN and test from their.

@rob729
Copy link
Contributor

rob729 commented Jan 24, 2020

@liveHarshit @iamareebjamal I created a new account on the app and then tested it. The app is working fine for the events liked after fossasia/open-event-server#6762 was fixed.
Can you please suggest me how to proceed on this issue further as I am not able to figure out what to do about liked events that are showing error when like is removed?

@ankushmundhra
Copy link

@Xsniper0 Is this issue still on? I think i may have an idea to solve this issue!

@VaibhavDM
Copy link
Author

VaibhavDM commented Jan 26, 2020 via email

@ankushmundhra
Copy link

@Xsniper0 Can i work on this?

@rob729
Copy link
Contributor

rob729 commented Jan 27, 2020

Yes

@VaibhavDM
Copy link
Author

VaibhavDM commented Jan 27, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants