Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove toasts in favor of Snackbars #785

Closed
iamareebjamal opened this issue Dec 28, 2018 · 6 comments
Closed

Remove toasts in favor of Snackbars #785

iamareebjamal opened this issue Dec 28, 2018 · 6 comments

Comments

@iamareebjamal
Copy link
Member

Toasts are kind of deprecated as any user who has disabled notifications for an app won't be able to see toast as well

Change toasts to snackbars wherever used

@GOVINDDIXIT
Copy link
Member

I want to take this issue

@iamareebjamal
Copy link
Member Author

Go ahead

@liveHarshit
Copy link
Member

@GOVINDDIXIT After login, snack for Welcome back! is shown in the login fragment. But the fragment is instantly pop out. Snack after auth should be shown in redirected fragment.

@GOVINDDIXIT
Copy link
Member

@liveHarshit thanks for pointing. Since, there is no post handler now. Thus it should be showed on redirected fragment, will fix it

@liveHarshit
Copy link
Member

@GOVINDDIXIT SnackBar is displaying at the top.

@GOVINDDIXIT
Copy link
Member

Created PR #918 for above issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants