fix: toast to snackbar for signup work #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
nikit19
previously requested changes
Jan 2, 2019
app/src/main/java/org/fossasia/openevent/general/auth/SignUpFragment.kt
Outdated
Show resolved
Hide resolved
|
@iamareebjamal pls review |
iamareebjamal
approved these changes
Jan 3, 2019
|
Create another issue to remove post handlers and pass intent to fragments telling them to show snackbars instead |
|
@iamareebjamal unable to get can you pls elaborate considering example of this case? |
|
You are using Handler to defer the transition. This has to be removed. SnackBar will instead be displayed in the target fragments/activities |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part for #785
fix #810
Screenshots for the change:
