fix: Stop creation of multiple listeners. #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikit19
reviewed
Feb 13, 2019
angmas1
changed the title
|
Yes, its a spotless kotlin error fixing it. |
| @@ -99,6 +99,7 @@ | |||
| android:id="@+id/eventsRecycler" | |||
| android:layout_width="match_parent" | |||
| android:layout_height="match_parent" | |||
| android:paddingTop="@dimen/padding_medium" | |||
There was a problem hiding this comment.
ShimmerEvents have have space near top which disappears when Events get loaded so added padding for consistency. Wanted to open another PR, but pushed in this by mistake. Do you want me to remove this or is it okay?
There was a problem hiding this comment.
Is this okay? @iamareebjamal
angmas1
changed the title
iamareebjamal
approved these changes
Feb 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1088
Changes: Moved code for creating listeners for which ever objects possible to onCreate instead of onCreateView so that they get created only once when fragment is created. Couldn't move some objects which relied on creation of rootview first.