fix: Selected image get rotate in edit profile (#1270) #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamanbansal
force-pushed
the
development
branch
from
5913160
to
bc59695
Compare
|
@iamareebjamal @liveHarshit @nikit19 please review this. |
iamanbansal
force-pushed
the
development
branch
from
bc59695
to
6300814
Compare
app/src/main/java/org/fossasia/openevent/general/RotateBitmap.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/RotateBitmap.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/auth/EditProfileFragment.kt
Outdated
Show resolved
Hide resolved
iamanbansal
force-pushed
the
development
branch
2 times, most recently
from
aee163f
to
54fa432
Compare
liveHarshit
reviewed
Apr 29, 2019
app/src/main/java/org/fossasia/openevent/general/auth/EditProfileViewModel.kt
Outdated
Show resolved
Hide resolved
|
@liveHarshit updated |
liveHarshit
reviewed
May 1, 2019
| @@ -0,0 +1,1430 @@ | |||
| { | |||
liveHarshit
previously approved these changes
May 2, 2019
app/src/main/java/org/fossasia/openevent/general/auth/EditProfileFragment.kt
Outdated
Show resolved
Hide resolved
nikit19
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1270
Changes:
Created RotateBitmap.kt file to prevent image from rotation
In EditProfileViewModel, created avatarUpdated, encodedImage, updatedImageTemp variable to retain the image.
Screenshots for the change:
