Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show skip button when only needed #2068

Merged
merged 1 commit into from Jul 5, 2019
Merged

fix: Show skip button when only needed #2068

merged 1 commit into from Jul 5, 2019

Conversation

anhanh11001
Copy link
Contributor

Details:

  • Change navigation from WelcomeFragment similar to eventbrite
  • Show skip button only when safeArgs attribute state so

Fixes: #2063

Screenshots for the change:
ezgif-4-006c79c28df0
ezgif-4-971e78f28730

@auto-label auto-label bot added the fix label Jul 5, 2019
Details:
- Change navigation from WelcomeFragment similar to eventbrite
- Show skip button only when safeArgs attribute state so

Fixes: #2063
@nikit19 nikit19 merged commit 90a1dad into fossasia:development Jul 5, 2019
@anhanh11001 anhanh11001 deleted the 2063_skip_wrong branch July 5, 2019 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip button appear in AuthFragment wrongly
3 participants