fix: Add error utils, fix stripe error message and charge data class #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikit19
previously approved these changes
Aug 13, 2019
| mutableMessage.value = resource.getString(R.string.payment_not_complete_message) | ||
| if (it is HttpException) { | ||
| val body = it.response()?.errorBody() | ||
| val jsonObject = JSONObject(body?.string()).getJSONArray(ERRORS)[0] |
There was a problem hiding this comment.
This will crash the app if not present
There was a problem hiding this comment.
So I think, try-catch can be used.
There was a problem hiding this comment.
Copy ErrorUtils from orga app and use getErrorDetails, so this can be handled once for everywhere
liveHarshit
force-pushed
the
2133
branch
2 times, most recently
from
1a8bc72
to
938cbc8
Compare
liveHarshit
changed the title
anhanh11001
reviewed
Aug 13, 2019
| errorCode == FORBIDDEN || | ||
| errorCode == NOT_FOUND || | ||
| errorCode == METHOD_NOT_ALLOWED || | ||
| errorCode == REQUEST_TIMEOUT) { |
There was a problem hiding this comment.
Is there any problem using Kotlin when expression for this here, I think it will look cleaner
There was a problem hiding this comment.
Sorry, can't get it?
There was a problem hiding this comment.
anhanh11001
previously approved these changes
Aug 13, 2019
ShridharGoel
previously approved these changes
Aug 13, 2019
liveHarshit
dismissed stale reviews from ShridharGoel and anhanh11001
via
83bba15
iamareebjamal
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2133