feat: Resume from my tickets after LOGIN #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liveHarshit
changed the title
nikit19
suggested changes
Sep 17, 2018
app/src/main/java/org/fossasia/openevent/general/auth/LoginFragment.kt
Outdated
Show resolved
Hide resolved
|
@liveHarshit also please add "fixes" issue number in the description so that when your PR gets merged the issue will also get closed |
|
Please follow commit guidelines |
Okay, Got it. 👍 |
nikit19
previously approved these changes
Sep 18, 2018
There was a problem hiding this comment.
We follow this guide for writing proper commit messages. Please read it https://chris.beams.io/posts/git-commit/
app/src/main/java/org/fossasia/openevent/general/auth/LoginFragment.kt
Outdated
Show resolved
Hide resolved
simarsingh24
previously approved these changes
Sep 18, 2018
iamareebjamal
requested changes
Sep 18, 2018
liveHarshit
force-pushed
the
development
branch
from
350a48b
to
601fe79
Compare
|
Updated |
nikit19
previously requested changes
Sep 20, 2018
app/src/main/java/org/fossasia/openevent/general/auth/LoginFragment.kt
Outdated
Show resolved
Hide resolved
liveHarshit
changed the title
liveHarshit
force-pushed
the
development
branch
3 times, most recently
from
1502a17
to
2426c3c
Compare
liveHarshit
changed the title
|
Updated, Sorry for all the complications. I will try best by next time. |
liveHarshit
changed the title
liveHarshit
force-pushed
the
development
branch
from
2426c3c
to
bc6d1b7
Compare
iamareebjamal
approved these changes
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #497