Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle all root layout fragments with navigation architecture #831

Merged
merged 1 commit into from Jan 4, 2019

Conversation

liveHarshit
Copy link
Member

Part of #822
Fixes #821

@liveHarshit
Copy link
Member Author

liveHarshit commented Jan 4, 2019

@iamareebjamal Why it is taking 10 - 15 minutes to build on PR while the build is done in 5 - 20 seconds on the terminal.

@iamareebjamal
Copy link
Member

iamareebjamal commented Jan 4, 2019

Because travis downloads Android SDK, all the libraries, starts gradle daemon and run the commands of build from cold without the build cache and run tests on a 1.5 GB RAM virtual machine. Locally this process will take hours

@iamareebjamal iamareebjamal merged commit 8a86976 into fossasia:development Jan 4, 2019
@liveHarshit liveHarshit deleted the navigation-1 branch January 5, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants