fix: Snackbar is appearing in the middle of the screen in eventDetailFragment #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in eventDetailFragment removed the coordinate layout from fragment_social_links added app:layout_dodgeInsetEdges="bottom" top frameLayout of fragment_event so whole thing shifts up when snackbar is shown fixed :fossasia#962
pranavpandey1998official
changed the title
|
Mention which issue it fixes in the description. |
| @@ -2,12 +2,8 @@ | |||
| <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android" | |||
There was a problem hiding this comment.
Change this framelayout to coordinator layout
There was a problem hiding this comment.
that was the bug if I changed it back then snackbar will take it as the first coordinate-Layout parent and appear as before
There was a problem hiding this comment.
if you want cordirdinate layout in view hiarchy we could nest it inside frameLayout
iamareebjamal
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #962 Snackbar is appearing in the middle of the screen in eventDetailFragment
removed the coordinate layout from fragment_social_links
added app:layout_dodgeInsetEdges="bottom" top frameLayout of fragment_event so whole thing shifts up when snackbar is shown
fix #962