This repository has been archived by the owner on Oct 9, 2020. It is now read-only.
Fixed #117 #88 #120
Merged
Fixed #117 #88 #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 24, 2015
| @@ -165,7 +166,7 @@ public boolean onQueryTextChange(String query) { | |||
| return true; | |||
| } | |||
|
|
|||
| private boolean haveNetworkConnection() { | |||
| public boolean haveNetworkConnection() { | |||
There was a problem hiding this comment.
it may be private also.not needed
There was a problem hiding this comment.
We should try to keep private methods only. Please fix it.
There was a problem hiding this comment.
ok...suerly I will make it private
|
Please squash. Always!! |
|
@mananwason Squashed it.Please review it. |
|
@mananwason is there any other issues with the code? |
|
No @opticod Merging. |
mananwason
added a commit
that referenced
this pull request
Jan 11, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In api/processor/*, for every success we are clearing the respective tables of database and adding new values.So, for every onRefresh(),its will clear the tables only when we have completed fetching that data else retain it. #88 #117