Activity ui #46
Activity ui #46
Conversation
| @@ -22,6 +22,8 @@ | |||
| */ | |||
| public class SpeakersListAdapter extends RecyclerView.Adapter<SpeakersListAdapter.ViewHolder> { | |||
| List<Speaker> speakers; | |||
| Context context; | |||
| private int lastPosition = -1; | |||
There was a problem hiding this comment.
use of this variable? and caching context again?
There was a problem hiding this comment.
I am using the variable for the entering animation. I'll remove the context.
|
@creativepsyco please check now. |
| */ | ||
| public class SpeakersActivity extends AppCompatActivity { | ||
| SessionsAdapter sessionsAdapter; | ||
| DbSingleton dbSingleton = DbSingleton.getInstance(); |
There was a problem hiding this comment.
DbSingleton is a singleton why do you have the need to cache it?
|
@creativepsyco fixed now. Please review. |
|
@creativepsyco @mananwason Just enquiring what is the status on this. I was thinking of working on the UI a little (making card based lists etc) so should I wait for this to merge ? |
|
@championswimmer I have already added card based lists in the code and I think that code was merged as well. Anyways I have improved some ui for the lists as well which is not in the PR. PFA screenshots. |
| } | ||
|
|
||
| @Override | ||
| public void onViewCreated(View view, @Nullable Bundle savedInstanceState) { | ||
| super.onViewCreated(view, savedInstanceState); | ||
| DbSingleton dbSingleton = DbSingleton.getInstance(); | ||
|
|
||
| LatLng latLng = new LatLng( |
There was a problem hiding this comment.
why are you getting the details from the db singleton? I think you can pass the necessary db info as a parameter to this view?
| @Override | ||
| public boolean onOptionsItemSelected(MenuItem item) { | ||
| switch (item.getItemId()) { | ||
| case android.R.id.home: | ||
| finish(); | ||
| return true; | ||
| case R.id.share_tracks: | ||
| //TODO: Add the real webapp links here | ||
| Intent intent = new Intent(); |
There was a problem hiding this comment.
You already have the webapp's URL you can create one using that.
There was a problem hiding this comment.
I did ask @championswimmer to discuss about this on gitter, so that we can add a webapp URL, which can be kept constant for all the webapps, that are deployed but I guess he forgot to answer or something.
There was a problem hiding this comment.
Okay please create a ticket, just having a TODO doesn't fix things.
There was a problem hiding this comment.
Already done that too fossasia/open-event-attendee-android#56
|
@mananwason still requires a bit of changes. |
|
@creativepsyco Can we merge this ? I'll make the changes in the next PR from the other branch such that we don't have any conflicts |
|
@mananwason let's get this PR fixed first. Otherwise there will be a bit more backlog work. |
|
Sure. I'll fix this first then. |
|
@creativepsyco Please check now. I have fixed everything |
|
@mananwason there is a build failure. This is the relevant error. The APT warning(Job{title=Cruncher ic_drawer.png, latch=BooleanLatch{signaled=false}, result=false}): /home/travis/build/fossasia/open-event-android/app/src/main/res/drawable-hdpi/ic_drawer.png: libpng warning: iCCP: Not recognizing known sRGB profile that has been edited
AAPT warning(Job{title=Cruncher ic_drawer.png, latch=BooleanLatch{signaled=false}, result=false}): /home/travis/build/fossasia/open-event-android/app/src/main/res/drawable-xhdpi/ic_drawer.png: libpng warning: iCCP: Not recognizing known sRGB profile that has been edited
AAPT warning(Job{title=Cruncher ic_drawer.png, latch=BooleanLatch{signaled=false}, result=false}): /home/travis/build/fossasia/open-event-android/app/src/main/res/drawable-mdpi/ic_drawer.png: libpng warning: iCCP: Not recognizing known sRGB profile that has been edited
:app:processFdroidDebugManifest
:app:processFdroidDebugResources Position 59:35-50 : No resource found that matches the given name (at 'resource' with value '@xml/searchable').I believe you forgot to commit the file? |
|
@creativepsyco I saw the error but I have committed the 2 files that are missing in this PR on https://github.com/mananwason/open-event-android/tree/details this branch. |
|
well you need to place the file in this commit or remove the line for the build to pass. |
|
Okay I'll add it. |
|
Okay so now I have added everything but travis is giving this error. I don't understand @creativepsyco |
|
@creativepsyco All fixed now. Please check and merge. |
* Smooth slide-up animation of Event Card now occurs * Smooth slide-up animation of Events now occurs
@creativepsyco Please review and merge