This repository has been archived by the owner on Oct 9, 2020. It is now read-only.
Session details, Bookmark, UI improvement, Code Cleanup #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 19, 2015
Closed
| for (int i = 0; i < getItemCount(); i++) { | ||
| Log.d("i" + i, tracks.get(i).getName()); | ||
| tracks.remove(i); | ||
| notifyItemRemoved(i); |
There was a problem hiding this comment.
I think should be done after you have finished removing? otherwise too many notify calls will cause too many getView calls.
There was a problem hiding this comment.
Yeah I'll change this
|
@mananwason Minor comments. Rest all looks good. we can merge this. but try to fix the issues in the next PR. |
creativepsyco
added a commit
that referenced
this pull request
Jul 22, 2015
Session details, Bookmark, UI improvement, Code Cleanup
dreadpool2
pushed a commit
to dreadpool2/open-event-android
that referenced
this pull request
Jun 7, 2018
* Sign Up Activity and ViewModel Made * Sign up activity and ViewModel made * fix: Sign Up Activity and ViewModel Made * Sign up activity and ViewModel made * Sign up activity and ViewModel made
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@creativepsyco Please review and merge.