Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed variable "name" to "event_name" #3545

Merged
merged 2 commits into from Nov 3, 2019
Merged

fix: changed variable "name" to "event_name" #3545

merged 2 commits into from Nov 3, 2019

Conversation

Batey96
Copy link
Member

@Batey96 Batey96 commented Oct 3, 2019

Fixes #3544

Short description of what this resolves:

There was a reference to an undefined variable "event_name" in app/templates/index.hbs which this PR fixes it by assigning a value of null to it in "app/controllers/index.js"

Changes proposed in this pull request:

The variable "name" in app/controllers/index.js was changed to "event_name" for a better reference

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow Semantic Naming .

@abhinavk96 abhinavk96 changed the title changed variable "name" to "event_name" fix: changed variable "name" to "event_name" Nov 3, 2019
@auto-label auto-label bot added the fix label Nov 3, 2019
@abhinavk96 abhinavk96 merged commit def6836 into fossasia:development Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference to undefined variable(event_name) in landingPage
3 participants