Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reduce eslint overrides #4764

Merged
merged 2 commits into from Aug 13, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Aug 13, 2020

  • Reduce ESLint overrides
  • Switch from let to const

@auto-label auto-label bot added the chore label Aug 13, 2020
@vercel
Copy link

vercel bot commented Aug 13, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/iyjh4je6o
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-eslint-more.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #4764 into development will not change coverage.
The diff coverage is 16.38%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4764   +/-   ##
============================================
  Coverage        22.86%   22.86%           
============================================
  Files              478      478           
  Lines             5051     5051           
  Branches             8        8           
============================================
  Hits              1155     1155           
  Misses            3895     3895           
  Partials             1        1           
Impacted Files Coverage Δ
app/components/account/application-section.js 6.25% <0.00%> (ø)
app/components/create-session-message.js 0.00% <0.00%> (ø)
app/components/events/view/export/api-response.js 27.27% <0.00%> (ø)
...n/settings/system/mail-settings/test-email-form.js 12.50% <0.00%> (ø)
...omponents/forms/admin/settings/ticket-fees-form.js 0.00% <0.00%> (ø)
...components/forms/events/view/create-access-code.js 0.00% <0.00%> (ø)
...mponents/forms/events/view/create-discount-code.js 0.00% <0.00%> (ø)
app/components/forms/orders/order-form.js 0.00% <0.00%> (ø)
app/components/forms/session-speaker-form.js 0.00% <0.00%> (ø)
app/components/forms/wizard/sponsors-step.js 0.00% <0.00%> (ø)
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 183a859...6d6e3e2. Read the comment docs.

@iamareebjamal iamareebjamal merged commit a1c4e43 into fossasia:development Aug 13, 2020
@iamareebjamal iamareebjamal deleted the eslint-more branch August 13, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant