Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Limit scheduler start and end time correctly #4789

Merged
merged 1 commit into from Aug 18, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Aug 18, 2020

Fixes #4788

@vercel
Copy link

vercel bot commented Aug 18, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/dvhu2ep3c
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-scheduler-timing.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #4789 into development will decrease coverage by 0.07%.
The diff coverage is 48.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4789      +/-   ##
===============================================
- Coverage        23.23%   23.16%   -0.08%     
===============================================
  Files              480      480              
  Lines             5039     5051      +12     
  Branches             9       14       +5     
===============================================
- Hits              1171     1170       -1     
- Misses            3867     3879      +12     
- Partials             1        2       +1     
Impacted Files Coverage Δ
app/models/event.js 53.84% <ø> (ø)
app/models/session.js 10.00% <ø> (ø)
app/models/speaker.js 0.00% <ø> (ø)
app/components/schedule.ts 48.00% <48.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5214898...ef277aa. Read the comment docs.

@iamareebjamal iamareebjamal merged commit cf2ed2b into fossasia:development Aug 18, 2020
@iamareebjamal iamareebjamal deleted the scheduler-timing branch August 18, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduler time limiting is wrong
1 participant