Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add position and organization column in speaker list #4834

Merged
merged 1 commit into from Aug 21, 2020

Conversation

snitin315
Copy link
Member

Fixes #4821

Short description of what this resolves:

Changes proposed in this pull request:

Screenshot at 2020-08-21 11-36-33

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Aug 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/5331b2yrs
✅ Preview: https://open-event-frontend-git-fork-snitin315-feat-pos-org.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #4834 into development will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4834      +/-   ##
===============================================
- Coverage        23.53%   23.48%   -0.06%     
===============================================
  Files              481      481              
  Lines             5085     5085              
  Branches            16       16              
===============================================
- Hits              1197     1194       -3     
- Misses            3884     3887       +3     
  Partials             4        4              
Impacted Files Coverage Δ
app/controllers/events/view/speakers/list.js 0.00% <ø> (ø)
app/routes/events/view/speakers/list.js 0.00% <ø> (ø)
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff4d641...0e35571. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 9a685be into fossasia:development Aug 21, 2020
@snitin315 snitin315 deleted the feat/pos-org branch August 21, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organizer Speakers List Page: Enhance column organization
2 participants