Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle undefined text color #4851

Merged

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Aug 23, 2020

Fixes #4850

  • Make helper handle temporary undefined values
  • Load sessions and tracks in one go for featured speakers
  • Filter speakers with deleted or unconfirmed sessions

@vercel
Copy link

vercel bot commented Aug 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/khl058j4p
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-text-color-undefined.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Aug 23, 2020

Codecov Report

Merging #4851 into development will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4851      +/-   ##
===============================================
+ Coverage        23.29%   23.30%   +0.01%     
===============================================
  Files              480      480              
  Lines             5082     5084       +2     
  Branches            16       17       +1     
===============================================
+ Hits              1184     1185       +1     
  Misses            3895     3895              
- Partials             3        4       +1     
Impacted Files Coverage Δ
app/routes/public/index.js 0.00% <ø> (ø)
app/helpers/text-color.ts 66.66% <66.66%> (-33.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4880985...8f0b97f. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 04f4420 into fossasia:development Aug 23, 2020
@iamareebjamal iamareebjamal deleted the text-color-undefined branch August 23, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session Items in Featured Speaker List not showing
1 participant