Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make calender height auto #4854

Merged
merged 5 commits into from Aug 24, 2020
Merged

fix: make calender height auto #4854

merged 5 commits into from Aug 24, 2020

Conversation

maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Aug 24, 2020

Fixes #4806

Screenshot from 2020-08-24 11-02-39

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Aug 24, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/ldfzxtq5b
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-patch-3.eventyay.vercel.app

@iamareebjamal
Copy link
Member

As mentioned in the issue, this will break UX in scheduler section of the organizer. Make this a prop, for example, puclic schedule will add @height="auto" to the Schedule component and organizer side won't so in public schedule, it'll be expanded and it will have a scrollbar in organizer section

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #4854 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4854   +/-   ##
============================================
  Coverage        23.30%   23.30%           
============================================
  Files              480      480           
  Lines             5084     5084           
  Branches            17       17           
============================================
  Hits              1185     1185           
  Misses            3895     3895           
  Partials             4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e67e366...14b9bd9. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview August 24, 2020 06:29 Inactive
@vercel vercel bot temporarily deployed to Preview August 24, 2020 06:30 Inactive
@maze-runnar
Copy link
Contributor Author

@iamareebjamal now it is auto on public and scroll on the scheduler.

Screenshot from 2020-08-24 12-02-59
Screenshot from 2020-08-24 12-02-27

@iamareebjamal iamareebjamal changed the title fix: make claender height auto fix: make calender height auto Aug 24, 2020
@iamareebjamal iamareebjamal merged commit f77aa00 into fossasia:development Aug 24, 2020
@maze-runnar maze-runnar deleted the patch-3 branch August 24, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public Event Schedule: Avoid in page scroll bar of schedule
2 participants