Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Schedule publish toggle crash #4878

Merged
merged 1 commit into from Aug 25, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Aug 25, 2020

Fixes #4868

Error introduced in https://github.com/fossasia/open-event-frontend/pull/4775/files#diff-cfb056a5cf26ae6847ecc6f81cc08d86R58, eventDetails was changed to event and remained to be replaced in one place in controller

@auto-label auto-label bot added the fix label Aug 25, 2020
@vercel
Copy link

vercel bot commented Aug 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/bhuzwdqro
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-schedule-publish.eventyay.vercel.app

Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ app/controllers/events/view/scheduler.js  -1
         

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #4878 into development will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4878      +/-   ##
===============================================
- Coverage        23.30%   23.19%   -0.11%     
===============================================
  Files              481      481              
  Lines             5090     5092       +2     
  Branches            18       18              
===============================================
- Hits              1186     1181       -5     
- Misses            3900     3907       +7     
  Partials             4        4              
Impacted Files Coverage Δ
app/controllers/events/view/scheduler.js 0.00% <0.00%> (ø)
app/components/smart-overflow.js 61.53% <0.00%> (-38.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b23d6f...e785285. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 4088e58 into fossasia:development Aug 25, 2020
@iamareebjamal iamareebjamal deleted the schedule-publish branch August 25, 2020 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish Schedule: Not possible to publish schedule, eternal loading icon
2 participants