Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Delete Space before Commas to format date #5124

Merged
merged 3 commits into from Sep 24, 2020
Merged

fix: Delete Space before Commas to format date #5124

merged 3 commits into from Sep 24, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #5122
scrnli_9_23_2020_10-44-35 AM
scrnli_9_23_2020_10-43-46 AM
scrnli_9_23_2020_10-42-14 AM

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Sep 23, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/ipaj7hckf
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-patch-2.eventyay.vercel.app

@auto-label auto-label bot added the fix label Sep 23, 2020
Raunaksingh100
Raunaksingh100 previously approved these changes Sep 23, 2020
View reviewed changes
@mariobehling
Copy link
Member

Actually, this bug appears mostly in date formats, but the issue is also related to other areas.

On the event dashboards there is an info box, where there is also a space before commas. Any other place where you see that issue?

  • session types
  • social media

Screenshot from 2020-09-23 11-41-55

mariobehling
mariobehling requested changes Sep 23, 2020
View reviewed changes
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also delete the space before commas elsewhere.

@maze-runnar
Copy link
Contributor Author

scrnli_9_23_2020_5-24-31 PM
scrnli_9_23_2020_5-23-55 PM

@mariobehling
Copy link
Member

This seems to be changed to lowercase now. The first letter should be capital as before in the social media services names.

@maze-runnar
Copy link
Contributor Author

This seems to be changed to lowercase now. The first letter should be capital as before in the social media services names.

it's not due to my change, that is a separate issue.

iamareebjamal
iamareebjamal reviewed Sep 23, 2020
View reviewed changes
app/templates/components/events/view/overview/general-info.hbs
{{if (not-eq index 0) ','}} {{sessionType.name}}
{{/each}}
{{~/each}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this removes unwanted space after each loop iteration

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://discuss.emberjs.com/t/removing-whitespace-with-angle-bracket-syntax/17094/9

mariobehling
mariobehling approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for me. Thank you!

@iamareebjamal iamareebjamal merged commit a0fe64e into fossasia:development Sep 24, 2020
@iamareebjamal
Copy link
Member

A test was failing, I didn't notice

@maze-runnar maze-runnar deleted the patch-2 branch December 13, 2020 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal left review comments

@mariobehling mariobehling mariobehling approved these changes

@Raunaksingh100 Raunaksingh100 Raunaksingh100 left review comments

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Date Format: Delete Space before Commas everywhere
4 participants
@maze-runnar @mariobehling @iamareebjamal @Raunaksingh100