-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Reorder and rename event dashboard boxes #5471
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/c61p4t344 |
Before and after screenshots |
Codecov Report
@@ Coverage Diff @@
## development #5471 +/- ##
============================================
Coverage 23.24% 23.24%
============================================
Files 493 493
Lines 5170 5170
Branches 38 38
============================================
Hits 1202 1202
Misses 3963 3963
Partials 5 5 Continue to review full report at Codecov.
|
And please resolve the conflicts |
@Soumi150 if someone do comment i am working on this so first ask that he is not working on it so can i work on it (It lead to duplicate work) plz follow the codeheat rules and community rules |
If @carrycooldude has a PR, we'll close this one. But we value actual contribution. Not just commenting "I want to work on this" and then disappearing on a trip to Bahamas. We will not stop other contributors from contributing just because someone commented "I want to work on this" or "I am working on this" If they have commented and started the work, they can send a PR, even an incomplete one as a proof and ask this PR to be closed. We'll do it without any problem. But it's in fashion these days to just say I want to work on this issue and then forget about it. Actual contributions are hurt because of this and this is bad for both the contributors who could fix the issue and get codeheat rewards and also for us because the issue doesn't get solved. For example, you can't just reserve a Phone from amazon and say "I'll pay for it" and prevent others from buying it. If you don't finalize payment within 2-3 hours, it'll be sold to someone else. We usually allow up to 7 days. But if someone else can immediately start working on something within hours and you haven't started working on it, the issue should go to that person. That's why please only comment on an issue you actually will be fixing and soon, otherwise anyone else who can send a PR soon will get that. And it is only fair |
Fixes #5468
Short description of what this resolves:
Reorder and rename event dashboard boxes.
Checklist
development
branch.Before
![Screenshot from 2020-11-03 11-58-40](https://user-images.githubusercontent.com/1583873/97977230-2b2f8300-1dcc-11eb-957b-396aa4bccc8c.png)
After making changes
![Screenshot (19)](https://user-images.githubusercontent.com/56203058/98011620-1c71bc00-1e1e-11eb-9c55-9ed2a2072c9b.png)