Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust table in Organizers Attendees Overview Page #5672

Merged

Conversation

sachinchauhan2889
Copy link
Contributor

Fixes #5669

Changes proposed in this pull request:

  • from the first column take out the emails
  • move "Date and Time" from first column to its own column
  • create a column for "Date and Time" between ticket name and ticket price
  • take out the xx days ago

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

screenshots

g1

@auto-label auto-label bot added the fix label Nov 17, 2020
@vercel
Copy link

vercel bot commented Nov 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/otwkc1unm
✅ Preview: https://open-event-frontend-git-enhance-attendee-table.eventyay.vercel.app

import Component from '@ember/component';

@classic
export default class CellTime extends Component {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need of empty components in octane

@@ -0,0 +1,5 @@
{{#if (eq this.record.status 'completed')}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@record

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #5672 (d861f60) into development (5d34f21) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5672      +/-   ##
===============================================
+ Coverage        23.72%   23.78%   +0.05%     
===============================================
  Files              498      498              
  Lines             5277     5277              
  Branches            47       47              
===============================================
+ Hits              1252     1255       +3     
+ Misses            4017     4014       -3     
  Partials             8        8              
Impacted Files Coverage Δ
.../controllers/events/view/tickets/attendees/list.js 0.00% <ø> (ø)
app/components/tabbed-navigation.js 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d34f21...d861f60. Read the comment docs.

Copy link
Member

@divyamtayal divyamtayal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the indentation of : in various places in list.hbs file

@iamareebjamal iamareebjamal changed the title fix: Adjust first column and move date in new column in Organizers Attendees Overview Page fix: Adjust table in Organizers Attendees Overview Page Nov 18, 2020
@iamareebjamal iamareebjamal merged commit 40a10d4 into fossasia:development Nov 18, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the enhance-attendee-table branch November 18, 2020 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organizers Attendees Overview Page: Adjust first column and move date
3 participants