Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: time standardization in two formats only #5747

Merged
merged 6 commits into from
Nov 26, 2020
Merged

fix: time standardization in two formats only #5747

merged 6 commits into from
Nov 26, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #5490
Make event format as in this example: 4 Dec, 2020 5:00 PM (IST)

call for speakers, e.g. https://eventyay.com/e/a315169f/cfs

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/pmyrykl4r
✅ Preview: https://open-event-frontend-git-time-standard-format.eventyay.now.sh

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #5747 (d9fbc88) into development (4006f52) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5747   +/-   ##
============================================
  Coverage        23.50%   23.50%           
============================================
  Files              512      512           
  Lines             5459     5459           
  Branches            62       62           
============================================
  Hits              1283     1283           
  Misses            4160     4160           
  Partials            16       16           
Impacted Files Coverage Δ
app/controllers/account/billing/invoices/list.js 100.00% <ø> (ø)
app/controllers/admin/sales/invoices.js 0.00% <ø> (ø)
app/controllers/admin/sessions/list.js 0.00% <ø> (ø)
app/controllers/admin/users/list.js 0.00% <ø> (ø)
app/controllers/events/list.js 23.07% <ø> (ø)
app/controllers/events/view/sessions/list.js 0.00% <ø> (ø)
app/controllers/events/view/tickets/orders/list.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4006f52...d9fbc88. Read the comment docs.

@mariobehling
Copy link
Member

Please also change using long version on:

  • frontpage event tiles
  • event pages above calendar icon

@mariobehling
Copy link
Member

Looks like you are changing the time format to 24 hours and show e.g. 13:00 PM. Please use standard time format and we need to take care that this is different in different languages.
Compare: https://open-event-frontend-git-time-standard-format.eventyay.vercel.app/e/3dbaaa50
See PR here as well #5748

@iamareebjamal
Copy link
Member

iamareebjamal commented Nov 25, 2020

Yes, there are far fewer changes in this PR than the previous one. Please keep all changes from the previous PR and fix the wrong things

@@ -9,9 +9,9 @@
<img src="{{this.model.logoUrl}}" class="logo mr-8" />
{{/if}}
<div>
<h4 class="event time">{{header-date this.model.startsAt this.model.timezone}}</h4>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why changed to general

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to move to a single helper, general-date

@@ -35,7 +35,7 @@ export default class extends Controller.extend(EmberTableControllerMixin) {
cellComponent : 'ui-table/cell/events/view/tickets/orders/cell-date',
headerComponent : 'tables/headers/sort',
width : 100,
dateFormat : 'MMMM DD, YYYY - HH:mm A',
Copy link
Member

@divyamtayal divyamtayal Nov 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls also correct this declaration, here I think we need to define dateFormat inside options as an object

@iamareebjamal iamareebjamal merged commit 53ce749 into fossasia:development Nov 26, 2020
@maze-runnar maze-runnar deleted the time-standard-format branch December 13, 2020 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date and Time: Standardize it across system
4 participants