-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: without email speaker going to my-session #5751
fix: without email speaker going to my-session #5751
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/o0i3pqah0 |
Codecov Report
@@ Coverage Diff @@
## development #5751 +/- ##
============================================
Coverage 23.42% 23.42%
============================================
Files 512 512
Lines 5469 5469
Branches 65 65
============================================
Hits 1281 1281
Misses 4171 4171
Partials 17 17
Continue to review full report at Codecov.
|
@@ -8,7 +8,7 @@ export default class extends Controller { | |||
if (this.addNewSpeaker) { | |||
const newSpeaker = this.model.speaker; | |||
if (newSpeaker.isEmailOverridden) { | |||
newSpeaker.set('email', this.authManager.currentUser.email); | |||
newSpeaker.set('email', " "); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
null
Is it working correctly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash your Commits
To ensure we understand the feature in the same way:
|
Means organizer can set email to null? |
server is giving 422 now:
|
Yes, only organizers can override email to null |
Fixes #5342
email is also required relation like track, so both needs to be make optional on server. That's why setting newSpeaker 'email' to " " .
Checklist
development
branch.