Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: without email speaker going to my-session #5751

Merged
merged 4 commits into from
Dec 2, 2020
Merged

fix: without email speaker going to my-session #5751

merged 4 commits into from
Dec 2, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #5342
email is also required relation like track, so both needs to be make optional on server. That's why setting newSpeaker 'email' to " " .

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Nov 25, 2020
@vercel
Copy link

vercel bot commented Nov 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/o0i3pqah0
✅ Preview: https://open-event-frontend-git-speaker-without-mail.eventyay.now.sh

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #5751 (92a4edf) into development (9d41e9e) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5751   +/-   ##
============================================
  Coverage        23.42%   23.42%           
============================================
  Files              512      512           
  Lines             5469     5469           
  Branches            65       65           
============================================
  Hits              1281     1281           
  Misses            4171     4171           
  Partials            17       17           
Impacted Files Coverage Δ
app/controllers/events/view/sessions/create.js 0.00% <0.00%> (ø)
app/controllers/events/view/sessions/edit.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d41e9e...92a4edf. Read the comment docs.

@@ -8,7 +8,7 @@ export default class extends Controller {
if (this.addNewSpeaker) {
const newSpeaker = this.model.speaker;
if (newSpeaker.isEmailOverridden) {
newSpeaker.set('email', this.authManager.currentUser.email);
newSpeaker.set('email', " ");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null

@iamareebjamal
Copy link
Member

Is it working correctly?

Copy link
Member

@NaviRocker NaviRocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash your Commits

@mariobehling
Copy link
Member

To ensure we understand the feature in the same way:

  1. Email is always required for speakers filling in the call for speakers.
  2. This can be overriden by the organizer, if they fill in a session submission themselves.

@maze-runnar
Copy link
Contributor Author

This can be overriden by the organizer, if they fill in a session submission themselves.

Means organizer can set email to null?

@maze-runnar
Copy link
Contributor Author

server is giving 422 now:

{"errors": [{"status": 422, "source": {"pointer": "/data/attributes"}, "title": "Unprocessable Entity", "detail": "Missing required fields ['email']"}], "jsonapi": {"version": "1.0"}}

@iamareebjamal
Copy link
Member

Yes, only organizers can override email to null

@iamareebjamal iamareebjamal merged commit a8f6ec6 into fossasia:development Dec 2, 2020
@maze-runnar maze-runnar deleted the speaker-without-mail branch December 2, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organizer: Adding speaker without email results in sessions added to "my sessions" from organizer him/herself
4 participants