Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dropdown menu results in internal scroll bar #5766

Merged
merged 7 commits into from Nov 28, 2020

Conversation

codepool867
Copy link
Contributor

@codepool867 codepool867 commented Nov 25, 2020

Fixes #5307

Short description of what this resolves:

Table height is adjusted to wax and wane automatically and dropdown direction is calculated properly.

Changes proposed in this pull request:

-Table::Default component is patched to emit action of rendering end.
-Pre-calculation of dropdown direction is implemented
-CellButton component is modified to add direction option

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/aovwxvyp8
✅ Preview: https://open-event-frontend-git-issue12.eventyay.now.sh

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #5766 (bc547f9) into development (a7dd303) will decrease coverage by 0.31%.
The diff coverage is 4.76%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5766      +/-   ##
===============================================
- Coverage        23.64%   23.32%   -0.32%     
===============================================
  Files              510      513       +3     
  Lines             5414     5457      +43     
  Branches            59       62       +3     
===============================================
- Hits              1280     1273       -7     
- Misses            4118     4168      +50     
  Partials            16       16              
Impacted Files Coverage Δ
.../components/forms/wizard/sessions-speakers-step.js 0.00% <ø> (ø)
app/controllers/events/view/sessions/list.js 0.00% <0.00%> (ø)
app/components/tables/default.js 100.00% <100.00%> (ø)
app/components/public/session-item.js 20.00% <0.00%> (-2.23%) ⬇️
app/router.js 100.00% <0.00%> (ø)
app/models/event.js 50.00% <0.00%> (ø)
app/models/session.js 10.00% <0.00%> (ø)
app/models/speaker.js 0.00% <0.00%> (ø)
app/models/social-link.js 0.00% <0.00%> (ø)
app/routes/public/sessions.js 0.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b18409...bc547f9. Read the comment docs.

Co-authored-by: Areeb Jamal <jamal.areeb@gmail.com>
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solution works for me. Thanks.

@iamareebjamal iamareebjamal changed the title Dropdown menu results in internal scroll bar fix: Dropdown menu results in internal scroll bar Nov 28, 2020
@iamareebjamal iamareebjamal merged commit 4c59354 into fossasia:development Nov 28, 2020
@auto-label auto-label bot added the fix label Nov 28, 2020
@iamareebjamal
Copy link
Member

Unfortunately, this causes #5834, so have to revert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organizer Session Page: Dropdown menu results in internal scroll bar
3 participants