Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding and removing field without error in wizard step 2 #5861

Merged
merged 2 commits into from
Dec 2, 2020
Merged

fix: Adding and removing field without error in wizard step 2 #5861

merged 2 commits into from
Dec 2, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #5855

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Dec 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/m5uspnins
✅ Preview: https://open-event-frontend-git-field-null.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #5861 (7d0d18f) into development (1e5239d) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5861      +/-   ##
===============================================
- Coverage        23.46%   23.44%   -0.02%     
===============================================
  Files              512      512              
  Lines             5460     5464       +4     
  Branches            63       63              
===============================================
  Hits              1281     1281              
- Misses            4163     4167       +4     
  Partials            16       16              
Impacted Files Coverage Δ
app/mixins/event-wizard.js 0.89% <ø> (ø)
app/components/forms/orders/order-form.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e5239d...7d0d18f. Read the comment docs.

@iamareebjamal
Copy link
Member

Great find, can you please explain why it was happening?

@iamareebjamal
Copy link
Member

Got it, ideally websites should be added in extra links, but anyway, great work

@iamareebjamal iamareebjamal merged commit b57e376 into fossasia:development Dec 2, 2020
@maze-runnar maze-runnar deleted the field-null branch December 2, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wizard Step 2: Adding and removing field again results in "field may not be null"
2 participants