Fixes the small screen overflow of order now button in tickets #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niranjan94
suggested changes
May 21, 2017
| @@ -61,8 +61,8 @@ | |||
| </div> | |||
| <div class="ui segment"> | |||
| <div class="ui grid"> | |||
| <div class="ui row grid"> | |||
| <div class="ui padding less fourteen wide column right aligned floated payment icons"> | |||
| <div class="ui row {{if device.isMobile 'stackable'}} grid"> | |||
There was a problem hiding this comment.
Stackable can always be there. it would come into effect only on smaller screens.
There was a problem hiding this comment.
@niranjan94 Yes !!. Changing it.
|
@niranjan94 done 👍 |
niranjan94
approved these changes
May 21, 2017
Codecov Report
@@ Coverage Diff @@
## development #66 +/- ##
============================================
Coverage 59.53% 59.53%
============================================
Files 121 121
Lines 944 944
============================================
Hits 562 562
Misses 382 382Continue to review full report at Codecov.
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
developmentbranch.Short description of what this resolves:
On the mobile portrait view, there is an overflow in the row containing order now button.
Changes proposed in this pull request:
Mobile portrait
Mobile landscape
Tablet
Fixes #65