fix: allow attendee checkin for several days #7391

maze-runnar · 2021-06-04T16:47:09Z

Fixes #2016

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

vercel · 2021-06-04T16:47:13Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/6f1pep9cmq9To1FGQotpAas6LnW2
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-date-filter-eventyay.vercel.app

codecov · 2021-06-04T21:45:06Z

Codecov Report

Merging #7391 (54c05e1) into development (929e9a2) will decrease coverage by 0.05%.
The diff coverage is 11.11%.

@@               Coverage Diff               @@
##           development    #7391      +/-   ##
===============================================
- Coverage        20.78%   20.73%   -0.06%     
===============================================
  Files              581      582       +1     
  Lines             6615     6623       +8     
  Branches           149      149              
===============================================
- Hits              1375     1373       -2     
- Misses            5213     5223      +10     
  Partials            27       27

Impacted Files	Coverage Δ
.../controllers/events/view/tickets/attendees/list.js	`0.00% <0.00%> (ø)`
.../cell/events/view/tickets/attendees/cell-action.js	`12.50% <12.50%> (ø)`
app/components/tabbed-navigation.js	`33.33% <0.00%> (-20.00%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 929e9a2...54c05e1. Read the comment docs.

mariobehling · 2021-06-06T03:46:40Z

Please add screenshots to all PRs.

maze-runnar · 2021-06-07T09:17:31Z

Please add screenshots to all PRs.

there is nothing to add as a screenshot in this PR, it can be tested only.

sachinchauhan2889

.

sachinchauhan2889 · 2021-06-09T09:33:46Z

app/controllers/events/view/tickets/attendees/list.js

@@ -74,7 +74,7 @@ export default class extends Controller.extend(EmberTableControllerMixin) {
    const attendee = this.store.peekRecord('attendee', attendee_id, { backgroundReload: false });
    attendee.toggleProperty('isCheckedIn');
    if (attendee.isCheckedIn) {
-      const newCheckinTimes = attendee.get('checkinTimes') === null ? `${moment().toISOString()}` : `${attendee.get('checkinTimes')},${moment().toISOString()}`;
+      const newCheckinTimes = attendee.get('checkinTimes') === null ? `${moment().toISOString()}` : `${moment().toISOString()}`;


Server is already merging times. Thats why i add this

The base branch was changed.

mariobehling · 2021-06-09T17:23:10Z

Please add screenshots.

maze-runnar · 2021-06-10T03:15:06Z

Please add screenshots.

Screencast.2021-06-10.08.44.34.mp4

maze-runnar added 2 commits June 4, 2021 21:56

it's all about logic

7f34c5d

fix s

9c37b6f

auto-label bot added the fix label Jun 4, 2021

vercel bot deployed to Preview June 4, 2021 16:47 View deployment

maze-runnar requested review from MeghalBisht, ranjitkshah and sachinchauhan2889 June 4, 2021 16:51

fix test try

ef09910

vercel bot deployed to Preview June 4, 2021 21:36 View deployment

sachinchauhan2889 assigned MeghalBisht, ranjitkshah and sachinchauhan2889 Jun 8, 2021

Merge branch 'testing' into date-filter

ee79726

vercel bot deployed to Preview June 8, 2021 10:35 View deployment

MeghalBisht previously approved these changes Jun 8, 2021

View reviewed changes

MeghalBisht removed their assignment Jun 9, 2021

ranjitkshah previously approved these changes Jun 9, 2021

View reviewed changes

sachinchauhan2889 reviewed Jun 9, 2021

View reviewed changes

fix checnkin time

ccc7491

sachinchauhan2889 dismissed stale reviews from ranjitkshah and MeghalBisht via ccc7491 June 9, 2021 09:24

vercel bot deployed to Preview June 9, 2021 09:24 View deployment

sachinchauhan2889 mentioned this pull request Jun 9, 2021

fix: allow attendee checkin for several days fossasia/open-event-server#8021

Merged

sachinchauhan2889 added the blocked-by-server label Jun 9, 2021

sachinchauhan2889 assigned maze-runnar and unassigned sachinchauhan2889 Jun 9, 2021

sachinchauhan2889 assigned MeghalBisht Jun 9, 2021

sachinchauhan2889 reviewed Jun 9, 2021

View reviewed changes

sachinchauhan2889 previously approved these changes Jun 9, 2021

View reviewed changes

maze-runnar dismissed sachinchauhan2889’s stale review via c1959c5 June 9, 2021 09:39

f

c1959c5

vercel bot deployed to Preview June 9, 2021 09:39 View deployment

sachinchauhan2889 previously approved these changes Jun 9, 2021

View reviewed changes

ranjitkshah previously approved these changes Jun 9, 2021

View reviewed changes

sachinchauhan2889 unassigned maze-runnar and ranjitkshah Jun 9, 2021

sachinchauhan2889 added the LGTM label Jun 9, 2021

Merge branch 'testing' into date-filter

30e5ab1

vercel bot deployed to Preview June 9, 2021 13:47 View deployment

MeghalBisht changed the base branch from testing to development June 9, 2021 15:59

Merge branch 'development' into date-filter

76521a1

vercel bot deployed to Preview June 9, 2021 16:00 View deployment

sachinchauhan2889 removed the blocked-by-server label Jun 9, 2021

Merge branch 'development' into date-filter

54c05e1

vercel bot deployed to Preview June 9, 2021 17:23 View deployment

MeghalBisht approved these changes Jun 9, 2021

View reviewed changes

MeghalBisht removed their assignment Jun 9, 2021

MeghalBisht removed the LGTM label Jun 10, 2021

maze-runnar closed this Jun 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: allow attendee checkin for several days #7391

fix: allow attendee checkin for several days #7391

maze-runnar commented Jun 4, 2021 •

edited by sachinchauhan2889

vercel bot commented Jun 4, 2021 •

edited

codecov bot commented Jun 4, 2021 •

edited

mariobehling commented Jun 6, 2021

maze-runnar commented Jun 7, 2021 •

edited

sachinchauhan2889 left a comment •

edited

sachinchauhan2889 Jun 9, 2021 •

edited

mariobehling commented Jun 9, 2021

maze-runnar commented Jun 10, 2021

fix: allow attendee checkin for several days #7391

fix: allow attendee checkin for several days #7391

Conversation

maze-runnar commented Jun 4, 2021 • edited by sachinchauhan2889

Checklist

vercel bot commented Jun 4, 2021 • edited

codecov bot commented Jun 4, 2021 • edited

Codecov Report

mariobehling commented Jun 6, 2021

maze-runnar commented Jun 7, 2021 • edited

sachinchauhan2889 left a comment • edited

Choose a reason for hiding this comment

sachinchauhan2889 Jun 9, 2021 • edited

Choose a reason for hiding this comment

mariobehling commented Jun 9, 2021

maze-runnar commented Jun 10, 2021

maze-runnar commented Jun 4, 2021 •

edited by sachinchauhan2889

vercel bot commented Jun 4, 2021 •

edited

codecov bot commented Jun 4, 2021 •

edited

maze-runnar commented Jun 7, 2021 •

edited

sachinchauhan2889 left a comment •

edited

sachinchauhan2889 Jun 9, 2021 •

edited