Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add group widget button #7845

Merged
merged 20 commits into from Sep 25, 2021

Conversation

maze-runnar
Copy link
Contributor

Fixes #7788
Screenshot from 2021-09-20 22-04-05
Screenshot from 2021-09-20 22-04-09

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Sep 22, 2021
@vercel
Copy link

vercel bot commented Sep 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/4Mkf9vZkT2pdJpHcArSNaPR4nDXp
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-group-widget-eventyay.vercel.app

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #7845 (e88a9b3) into development (08abb76) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7845      +/-   ##
===============================================
- Coverage        18.57%   18.55%   -0.03%     
===============================================
  Files              613      614       +1     
  Lines             7198     7206       +8     
  Branches           149      149              
===============================================
  Hits              1337     1337              
- Misses            5834     5842       +8     
  Partials            27       27              
Impacted Files Coverage Δ
app/helpers/confirm.js 15.38% <0.00%> (-4.62%) ⬇️
app/controllers/public/index.js 6.41% <0.00%> (ø)
app/models/order.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08abb76...e88a9b3. Read the comment docs.

@mariobehling
Copy link
Member

Please also

  1. On top of "Follow button" a Row with logo of group, name of group

Goal is to have kind of a widget.
So, please move the name of the group above the button itself. Reason is that many groups have longer names and do not fit nicely into the buttons.

@maze-runnar
Copy link
Contributor Author

maze-runnar commented Sep 23, 2021

@mariobehling is this ok?
Screenshot from 2021-09-23 21-17-34
Screenshot from 2021-09-23 21-17-38

@mariobehling
Copy link
Member

mariobehling commented Sep 23, 2021

Could you make it a bit more like the screenshot below.

134540754-8ab3e3e4-7354-4745-a9c0-8e2b2e1130e5

Can you confirm that you show the group logo/icon, not the group background image, please?

@mariobehling
Copy link
Member

Please also change:

  • Red color for "Following" should also be blue (no need to have the red color)
  • Add a bit of spacing on between "Follow Group/Following" text and icons (on the left and right)

@maze-runnar
Copy link
Contributor Author

Please also change:

  • Red color for "Following" should also be blue (no need to have the red color)
  • Add a bit of spacing on between "Follow Group/Following" text and icons (on the left and right)

Done
Screenshot from 2021-09-24 08-11-23

@mariobehling
Copy link
Member

Thanks. Please also

  • Link the logo and group name to the public group page
  • Add a spacing above the widget. There is very little space to the above widget.

Compare https://open-event-frontend-git-fork-maze-runnar-group-widget-eventyay.vercel.app/e/c5fc6d42

Screenshot from 2021-09-24 06-10-14

@mariobehling mariobehling merged commit 4cca2c8 into fossasia:development Sep 25, 2021
@maze-runnar maze-runnar deleted the group-widget branch September 25, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a "Group Widget" on the right side bar of events
2 participants