Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user not able to delete other followers #7849

Merged
merged 5 commits into from Sep 25, 2021

Conversation

maze-runnar
Copy link
Contributor

Fixes #7691

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Sep 24, 2021
@vercel
Copy link

vercel bot commented Sep 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/2Xyz2GBt9824MLqd6jDt2GNC4Lxr
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-follow-688a18-eventyay.vercel.app

@maze-runnar
Copy link
Contributor Author

@daretobedifferent18 @pc-beast please test it.

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #7849 (6e9d6f3) into development (8f6399b) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7849      +/-   ##
===============================================
- Coverage        18.59%   18.52%   -0.07%     
===============================================
  Files              614      615       +1     
  Lines             7206     7217      +11     
  Branches           149      149              
===============================================
- Hits              1340     1337       -3     
- Misses            5839     5853      +14     
  Partials            27       27              
Impacted Files Coverage Δ
app/components/forms/group/group-view.js 0.00% <0.00%> (ø)
app/controllers/group-public.js 0.00% <0.00%> (ø)
app/models/user.js 0.00% <ø> (ø)
app/routes/group-public.js 0.00% <ø> (ø)
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f6399b...6e9d6f3. Read the comment docs.

@mariobehling
Copy link
Member

Could you post a screenshot and test link, please? I do not remember exactly where the user could previously remove other users.

I do not see that this is possible now.

@maze-runnar
Copy link
Contributor Author

follow/unfollow from group view page was giving many unexpected error. And admin was able to remove all followers by clicking on follow button continuously. this PR solve both issues.
Screenshot from 2021-09-24 20-57-31

@pc-beast
Copy link
Member

Before changes, it was showing 'access forbidden error'
image

Now it works as expected.

@mariobehling mariobehling merged commit 18d895e into fossasia:development Sep 25, 2021
@maze-runnar maze-runnar deleted the follow-unfollowe branch November 1, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group View Page: User able to remove other followers
4 participants