Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make ticket holder info editable #7948

Merged
merged 5 commits into from Nov 9, 2021

Conversation

maze-runnar
Copy link
Contributor

Fixes #7906

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the feature label Oct 18, 2021
@vercel
Copy link

vercel bot commented Oct 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/Hyf6SKtpDNHJjpRwoRMGDPmE56dR
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-edit-attendee-eventyay.vercel.app

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #7948 (df87b6a) into development (8d3f29e) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7948      +/-   ##
===============================================
- Coverage        18.57%   18.55%   -0.02%     
===============================================
  Files              620      620              
  Lines             7423     7431       +8     
  Branches           149      149              
===============================================
  Hits              1379     1379              
- Misses            6016     6024       +8     
  Partials            28       28              
Impacted Files Coverage Δ
app/components/forms/orders/attendee-list.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d3f29e...df87b6a. Read the comment docs.

@mariobehling
Copy link
Member

Please add some screenshots.

@pc-beast
Copy link
Member

Screenshot

image

@maze-runnar
Copy link
Contributor Author

When you click on download ticket, you should get prompt msg.

@maze-runnar
Copy link
Contributor Author

maze-runnar commented Oct 22, 2021

@pc-beast
Screenshot from 2021-10-22 08-07-29

@mariobehling
Copy link
Member

This issue was mainly about the attendee form fields that are configured in the wizard. Can the attendee change what he/she entered here previously?

Screenshot from 2021-10-22 06-39-03

@maze-runnar
Copy link
Contributor Author

@mariobehling I have made the required changes, please review

Copy link
Member

@pc-beast pc-beast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Dropdown fields are not editable.

@maze-runnar maze-runnar closed this Nov 1, 2021
@maze-runnar maze-runnar deleted the edit-attendee branch November 1, 2021 02:25
@mariobehling
Copy link
Member

Was this closed accidentally? Ok, lets follow up elsewhere.

@maze-runnar maze-runnar restored the edit-attendee branch November 1, 2021 14:44
@maze-runnar maze-runnar reopened this Nov 1, 2021
@maze-runnar
Copy link
Contributor Author

Closed accidently.

@maze-runnar
Copy link
Contributor Author

image Dropdown fields are not editable.

can't make select editable really.

@mariobehling mariobehling merged commit fc05651 into fossasia:development Nov 9, 2021
@mariobehling
Copy link
Member

I have tested that in more detail now. Unfortunately the process is not yet ready for users.

After an order is made the user can still change data, but there is no way to save it. It lacks a save button. Also changes are not reflected on the ticket. Expected would be a button "Edit Attendee Information" and "Save". Fields should only become editable after the user has pressed "Edit". This might have to implemented in a separate page.

So, for now I am reverting this and I hope the remaining parts can be taken care of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the ticket holder information editable
4 participants