Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tax modal not working sometimes #7959

Merged
merged 3 commits into from Oct 20, 2021

Conversation

maze-runnar
Copy link
Contributor

Fixes #logic change for whole tax creation

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Oct 20, 2021
@vercel
Copy link

vercel bot commented Oct 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/C7WH7dCZr2F5eoAa7dEfbD8SPXBn
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-new-tax-eventyay.vercel.app

@maze-runnar
Copy link
Contributor Author

@pc-beast @progmatic-99 please test.

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #7959 (da75811) into development (85a6cd8) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7959      +/-   ##
===============================================
- Coverage        18.79%   18.78%   -0.02%     
===============================================
  Files              616      616              
  Lines             7280     7284       +4     
  Branches           149      149              
===============================================
  Hits              1368     1368              
- Misses            5884     5888       +4     
  Partials            28       28              
Impacted Files Coverage Δ
app/components/forms/wizard/basic-details-step.js 18.91% <0.00%> (-0.71%) ⬇️
app/routes/create.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85a6cd8...da75811. Read the comment docs.

@mariobehling
Copy link
Member

The bug is solved, but I do not see all available info as resolved here #7887. Therefore updating it.

Copy link
Member

@pc-beast pc-beast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍

@maze-runnar maze-runnar merged commit 108d8b8 into fossasia:development Oct 20, 2021
@maze-runnar maze-runnar deleted the new-tax branch October 20, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants